1241665 - MacIOSurfaceTextureSourceBasic needs to handle video formats

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Markus Stange [:mstange]]

MacIOSurfaceTextureSourceBasic::GetSurface calls MacIOSurface::GetAsSurface which doesn't handle video formats and creates bad surfaces.

Comment 1

[Markus Stange [:mstange]]

Attachment: MozReview Request: Bug 1241665 - Move IOSurface YCbCr conversion code to a new file MacIOSurfaceHelpers.cpp. r?mattwoodrow

Ideally this would live in gfx/2d/MacIOSurface.cpp, but we don't have access to the
YCbCr conversion utilities in Moz2D.

Review commit: https://reviewboard.mozilla.org/r/31847/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31847/

Comment 2

[Markus Stange [:mstange]]

Attachment: MozReview Request: Bug 1241665 - Correctly convert IOSurfaces to SourceSurfaces in MacIOSurfaceTextureSourceBasic and MacIOSurfaceTextureData. r?mattwoodrow

Review commit: https://reviewboard.mozilla.org/r/31849/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31849/

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8710721 [details]
MozReview Request: Bug 1241665 - Move IOSurface YCbCr conversion code to a new file MacIOSurfaceHelpers.cpp. r?mattwoodrow

https://reviewboard.mozilla.org/r/31847/#review28577

Comment 4

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8710722 [details]
MozReview Request: Bug 1241665 - Correctly convert IOSurfaces to SourceSurfaces in MacIOSurfaceTextureSourceBasic and MacIOSurfaceTextureData. r?mattwoodrow

https://reviewboard.mozilla.org/r/31849/#review28581

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b07035a777bb
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e0f1024dbc9

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b07035a777bb
https://hg.mozilla.org/mozilla-central/rev/2e0f1024dbc9

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Markus, we need this patch to be uplifted to 45 to be able to land bug 1187322? Could you take care of the uplift request? Thanks

Comment 8

[Markus Stange [:mstange]]

Comment on attachment 8710721 [details]
MozReview Request: Bug 1241665 - Move IOSurface YCbCr conversion code to a new file MacIOSurfaceHelpers.cpp. r?mattwoodrow

Approval Request Comment
[Feature/regressing bug #]: BasicCompositor on OS X
[User impact if declined]: crashes and no video when hardware acceleration is off
[Describe test coverage new/current, TreeHerder]: none (we don't run any tests with hardware acceleration disabled on OS X)
[Risks and why]: very low, just makes us use proven conversion code in more places
[String/UUID change made/needed]: none

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8710721 [details]
MozReview Request: Bug 1241665 - Move IOSurface YCbCr conversion code to a new file MacIOSurfaceHelpers.cpp. r?mattwoodrow

That was fast, thanks!
Taking it as it fixes crashes.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cb7ae108000d
https://hg.mozilla.org/releases/mozilla-aurora/rev/bbf2df5dba13