1241679 - WebDriver:Navigate times out when trying to import a certificate because a modal sheet gets opened

Status: RESOLVED INVALID

(Remote Protocol :: Marionette, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: minimized testcase

The following testcase does currently not work in Marionette because navigate() blocks and does not return from loading the page.

If that is a case we cannot handle via navigate() the workaround would be to enter the url in the location bar and press return.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Could possibly block conformance.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Bug 1477977 is what we actually want.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Marionette test

Updated Marionette test because mozqa.com doesn't exist anymore.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With the patch from bug 1477977 landed I can see the following entry in the trace log:

1560510362295 Marionette TRACE Received observer notification toplevel-window-ready

That means it is not a modal dialog what gets opened here, but a modal sheet which behaves like a window, but blocks the navigation in Firefox. As result no further page load events are getting emitted, and the command doesn't return until it hits the timeout.

Given that this is a very rare case any kind of investigation will have lower priority.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

When I run this test with Marionette I cannot see an observer notification that a modal dialog has been opened for the CA alert [1]. There is only the DOMWillOpenModalDialog event fired. I wonder why that happens.

Olli, is that expected? If yes, why we don't get common-dialog-loaded nor tabmodal-dialog-loaded notifications here? As it looks like the same happens for the Clear Recent History dialog too.

[1] https://searchfox.org/mozilla-central/rev/1133b6716d9a8131c09754f3f29288484896b8b6/security/manager/ssl/nsNSSCertificateDB.cpp#329

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Note that we also get a toplevel-window-ready notification, maybe this is something we would have to check if a modal dialog or window has been opened?

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

(this was discussed at Whistler. Re-needinfo if there is still something unclear.)

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The test case from comment 3 doesn't work anymore because there is no support for md5 and as such I removed it from my page.

Dana, is there still a way to import a certificate by navigating to a URL? If yes, do you have an example URL that I could use to check the behavior in Marionette these days? The navigation should bring up a modal sheet /dialog. If there is no support anymore we most likely can close this bug.

Comment 9

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Importing a certificate by navigating to a URL was removed in bug 1024871, so it looks like we can close this.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Dana! Indeed, so lets close.