1241713 - [UX] Devices List

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Refer to the user story in bug 1172309.

Currently this work includes a list of popular devices as well as a way to edit the list.

If the initial list presented is just "popular" devices, we should think about how (if at all) we use the data from other devices in our device DB.  Do we only allow "promoting" others from the DB to the main list, or can you free form enter an entirely new custom device?

Comment 1

[Helen V. Holmes (:helenvholmes) (:✨)]

Ryan, is this bug to handle a) the UX of promoting devices from one list to another via some sort of settings, or b) the creation of the list itself?

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Helen V. Holmes (:helenvholmes) (:✨) from comment #1)
> Ryan, is this bug to handle a) the UX of promoting devices from one list to
> another via some sort of settings, or b) the creation of the list itself?

So far, we've just been making on UX bug per user story, so I meant for this to encompass all the points in bug 1172309.  (We can certainly make more UX bugs if we want to!)

From the current story text, I am imagining we need at least:

* A list of devices somewhere that we can choose from to apply their attributes
* Any changes (if we are planning any, we may not be) to the overall UI when a device is selected vs. a random size
* Some way to change the list

It's not super clear to me from the story what "change the list" means.  Did we agree to only support "promoting" to a default list from our larger DB, or is there also addition of user-defined devices as well?

Maybe Bryan can help, I can't quite remember.

Comment 3

[Marco Mucci [:MarcoM]]

You can definitely file more UX bugs if you want to breakdown the UX work further.

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #2)
> It's not super clear to me from the story what "change the list" means.  Did
> we agree to only support "promoting" to a default list from our larger DB,
> or is there also addition of user-defined devices as well?
> 
> Maybe Bryan can help, I can't quite remember.

This is going to depend a bit on what helen is thinking for the layout of the UX.  For the initial version I think we can support only "promoting" a device to the default list.

Comment 5

[Helen V. Holmes (:helenvholmes) (:✨)]

Attachment: device-list-ux-notes.png

The viewport should have a select box at the top with a curated list of devices. (I've put a few suggestions in my designs which I'll transcribe at the bottom, although they're not backed by any data yet.)

The last option in the select should be "Edit list..." which pops up a modal if selected.

The modal has all of the devices from Jan's device list CDN, excluding the devices that have been marketed as Firefox OS devices. In the future, we should be able to make changes to the CDN and have the RDM modal/lists update pretty easily.

The 'x' on the modal closes the modal without saving the user selections.

Hitting 'done' closes the modal, saving the user selections. 

The select box should display the devices alphabetically.