1241727 - WebKitCSSMatrix inverse() should throw NotSupportedError

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect)

Description

[Mike Taylor [:miketaylr]]

DOMMatrixReadyOnly.invertSelf() says to return a pile of NaNs, but WebKitCSSMatrix should actually throw a NotSupportedError DOMException to be compatible with Blink and WebKit.

I've updated the spec to match their behavior in https://github.com/whatwg/compat/commit/b649853f2c35cd9def15fbef6c35eac2a6e43aa9.

Comment 1

[Mike Taylor [:miketaylr]]

Note: we don't know if this is actually needed for webcompat -- but it matches the behavior of Safari, Chrome and Edge (and is required to pass WebKit layout tests).

Comment 2

[William Chen [:wchen]]

Attachment: Inverting non-invertable WebKitCSSMatrix should throw NotSupportedError.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/efbb834ec2fd

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/efbb834ec2fd

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/efbb834ec2fd

Comment 6

[Mike Taylor [:miketaylr]]

Comment on attachment 8711250 [details] [diff] [review]
Inverting non-invertable WebKitCSSMatrix should throw NotSupportedError.

Approval Request Comment
[Feature/regressing bug #]:

Bug 717722 for WebKitCSSMatrix support.

[User impact if declined]:

Unknown. It makes us less compatible with Chrome, Safari and Edge in theory. In practice we don't know if sites are broken as a result -- but it would be ideal to ship WebKitCSSMatrix and its related bug fixes in the same release (even if it won't ship past Aurora for the time being).

[Describe test coverage new/current, TreeHerder]:
Tests in patch.

[Risks and why]: 
For web content, there's low risk. No web content is depending on the previous (spec-bug) behavior. Web content may be depending on the behavior this fix provides.


[String/UUID change made/needed]:
None (UUID changes are not for webidl, right?)

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8711250 [details] [diff] [review]
Inverting non-invertable WebKitCSSMatrix should throw NotSupportedError.

Improves web compat, includes tests. SGTM! Please uplift to aurora.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9007341ca1c6