Open Bug 1242045 Opened 8 years ago Updated 2 years ago

Include a name in the #endif for all include guards

Categories

(Core :: JavaScript Engine, defect)

defect

Tracking

()

Tracking Status
firefox46 --- affected

People

(Reporter: terrence, Unassigned)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

And regularize spacing, etc. This patch was edited together manually with the list was generated by:

'''bash
#!/bin/bash
FILES=`find . -name "*.h" | grep -v irreg | grep -v libffi | grep -v vixl | grep -v editline | grep -v vtune | grep -v style | grep -v llvm-compiler-rt | grep -v js-conf`

for FILE in $FILES; do
    GUARDNAME=`sed -n "s/#ifndef \(.*_h\)$/\1/p" ${FILE}`
    if [ -z $GUARDNAME ]; then
        echo "Missing guard in: "$FILE
        exit 1
    fi

    grep -q "#endif....${GUARDNAME}" ${FILE} || echo "Missing end name in ${FILE}"
done

'''
Blocks: 1242060
Component: JavaScript: GC → JavaScript Engine
Do we want to switch the existing /* */ end names to use // while we're at it? While we're nitpicking :)
Assignee: terrence.d.cole → nobody
Status: ASSIGNED → NEW
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: