Open
Bug 1242045
Opened 8 years ago
Updated 2 years ago
Include a name in the #endif for all include guards
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
NEW
Tracking | Status | |
---|---|---|
firefox46 | --- | affected |
People
(Reporter: terrence, Unassigned)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
5.25 KB,
patch
|
Details | Diff | Splinter Review |
And regularize spacing, etc. This patch was edited together manually with the list was generated by: '''bash #!/bin/bash FILES=`find . -name "*.h" | grep -v irreg | grep -v libffi | grep -v vixl | grep -v editline | grep -v vtune | grep -v style | grep -v llvm-compiler-rt | grep -v js-conf` for FILE in $FILES; do GUARDNAME=`sed -n "s/#ifndef \(.*_h\)$/\1/p" ${FILE}` if [ -z $GUARDNAME ]; then echo "Missing guard in: "$FILE exit 1 fi grep -q "#endif....${GUARDNAME}" ${FILE} || echo "Missing end name in ${FILE}" done '''
Reporter | ||
Updated•8 years ago
|
Component: JavaScript: GC → JavaScript Engine
Comment 1•8 years ago
|
||
Do we want to switch the existing /* */ end names to use // while we're at it? While we're nitpicking :)
Updated•3 years ago
|
Assignee: terrence.d.cole → nobody
Status: ASSIGNED → NEW
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•