Closed
Bug 1242120
Opened 8 years ago
Closed 8 years ago
Remove switch fallthrough to avoid -Wimplicit-fallthrough warning in dom/canvas/
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
|
1.54 KB,
patch
|
mtseng
:
review+
|
Details | Diff | Splinter Review |
clang's -Wimplicit-fallthrough warnings (not yet enabled in mozilla-central) warn about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH (bug 1215411) is an annotation to suppress -Wimplicit-fallthrough warnings where the fallthrough is intentional, but in this case, the switch code can be rearranged to return without falling through. dom/canvas/WebGLContextGL.cpp:1329:9: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
Attachment #8711288 -
Flags: review?(mtseng)
|
||
Updated•8 years ago
|
Attachment #8711288 -
Flags: review?(mtseng) → review+
|
Assignee | |
Comment 1•8 years ago
|
||
Thanks for the fast review! :)
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/efdb4c508dd3
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•