Closed
Bug 1242567
Opened 8 years ago
Closed 8 years ago
OptionsPanel.show should use Task to simplify its implementation
Categories
(DevTools :: Framework, defect)
DevTools
Framework
Tracking
(firefox47 fixed)
RESOLVED
FIXED
Firefox 47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file, 2 obsolete files)
2.50 KB,
patch
|
ochameau
:
review+
|
Details | Diff | Splinter Review |
Followup of bug 1239287 comment 7.
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=df1cc821d623
Comment 3•8 years ago
|
||
Comment on attachment 8711693 [details] [diff] [review] patch v1 Review of attachment 8711693 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/client/framework/toolbox-options.js @@ +99,3 @@ > // For local debugging we need to make the target remote. > if (!this.target.isRemote) { > + this.target.makeRemote(); Should this be yielding?
Assignee | ||
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=05e1bc2a9e28
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #3) > Comment on attachment 8711693 [details] [diff] [review] > patch v1 > > Review of attachment 8711693 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: devtools/client/framework/toolbox-options.js > @@ +99,3 @@ > > // For local debugging we need to make the target remote. > > if (!this.target.isRemote) { > > + this.target.makeRemote(); > > Should this be yielding? Yes...
Attachment #8711763 -
Flags: review?(bgrinstead)
Assignee | ||
Updated•8 years ago
|
Attachment #8711693 -
Attachment is obsolete: true
Comment 6•8 years ago
|
||
Comment on attachment 8711763 [details] [diff] [review] patch v2 Review of attachment 8711763 [details] [diff] [review]: ----------------------------------------------------------------- Works for me, thanks
Attachment #8711763 -
Flags: review?(bgrinstead) → review+
Assignee | ||
Comment 7•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd00acdc48ba
Assignee | ||
Comment 8•8 years ago
|
||
Forgot to also `return this;` at end of open.
Attachment #8712062 -
Flags: review+
Assignee | ||
Updated•8 years ago
|
Attachment #8711763 -
Attachment is obsolete: true
Assignee | ||
Comment 9•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a36366199462d51c8f7b3cf6ccce27f52fbedb34 Bug 1242567 - Cleanup OptionsPanel.open by using Task.async. r=bgrins
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a36366199462
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•