Closed
Bug 124273
Opened 23 years ago
Closed 22 years ago
RDF-ification of the help system
Categories
(SeaMonkey :: Help Documentation, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.9
People
(Reporter: oeschger, Assigned: oeschger)
References
()
Details
(Whiteboard: [adt3])
Attachments
(8 files, 3 obsolete files)
339.38 KB,
patch
|
hewitt
:
review+
hewitt
:
superreview+
|
Details | Diff | Splinter Review |
11.68 KB,
patch
|
Details | Diff | Splinter Review | |
27.97 KB,
patch
|
Details | Diff | Splinter Review | |
2.00 KB,
patch
|
Details | Diff | Splinter Review | |
2.32 KB,
patch
|
Details | Diff | Splinter Review | |
13.10 KB,
patch
|
Details | Diff | Splinter Review | |
17.30 KB,
patch
|
Details | Diff | Splinter Review | |
17.26 KB,
patch
|
oeschger
:
review+
hewitt
:
superreview+
|
Details | Diff | Splinter Review |
Help system should be more dynamic than it is now, and determine which content to load based on what components are available. RDF-ification in patch to be posted here shortly also provides a client-side search capability, some sidebar-like panels on the left, and better use of templates there as well. See spec at URL above for more info.
Setting nsbeta1+, 0.9.9 milestone.
Keywords: nsbeta1+
Target Milestone: --- → mozilla0.9.9
Assignee | ||
Comment 2•23 years ago
|
||
Updated patch from 67376: this one has been cleaned up, includes the fix for the retired outlinerbody stuff (so now it works), includes some cleaning out of the old, no-longer-used help files, has an updated toc and index.
Comment 3•23 years ago
|
||
Comment on attachment 68454 [details] [diff] [review] update for help system: rdfification r=hewitt sr=waterson (from earlier)
Attachment #68454 -
Flags: superreview+
Attachment #68454 -
Flags: review+
Assignee | ||
Comment 4•23 years ago
|
||
We also have to change references to help.js to contextHelp.js in the UI where openHelp() is being called. This patch is an update for all the places in security that need the update. Working on the dozen or so others.
Updated•23 years ago
|
Attachment #68471 -
Flags: review+
Assignee | ||
Comment 5•23 years ago
|
||
This patch updates all references to help.js in the editor dialogs.
Assignee | ||
Comment 6•23 years ago
|
||
actually, scratch that. This one is the real one. The syntax for opening help has changed too: the function does not need to include the url anymore.
Attachment #68474 -
Attachment is obsolete: true
Assignee | ||
Comment 7•23 years ago
|
||
sigh...another update. This includes the help.js->contextHelp.js updates I made in security but also has the update for the syntax of openHelp, which now *doesn't* want to old url to the help window, chrome://help/content/help.xul, but *does* want the key by itself of a full url like this: chrome://help/locale/mozillahelp.rdf?key, where mozillahelp.rdf is the rdf file at the top of the help system that spells out what content is available.
Attachment #68471 -
Attachment is obsolete: true
Assignee | ||
Comment 8•23 years ago
|
||
update to preferences dialog: hooks context sensitive help back up post help check-in
Assignee | ||
Comment 9•23 years ago
|
||
I think this is the last one we need: the AccountManger dialog also needs to be updated to ask for help in the right way (i.e., without the chrome://help/content/help.xul) and from the right file (contextHelp.js).
Assignee | ||
Comment 10•23 years ago
|
||
Jag - Can I have your practiced eye on these updates to spots in the UI where help is being asked for with context? I had to update the file that gets included (contextHelp.js) and the syntax of openHelp().
Status: NEW → ASSIGNED
Comment 11•23 years ago
|
||
Hey, Ian. Can you remove the 'xmlns:html' from the window element in 'help.xul'. One, it's not needed, and two, the namespace 'REC-html40' is long obsolete.
Assignee | ||
Comment 12•23 years ago
|
||
Roger, John. I'll pull it out next time I go in with an update. Thanks.
Assignee | ||
Comment 13•23 years ago
|
||
Assignee | ||
Comment 14•22 years ago
|
||
This patch fixes the following bugs in one big schmear: 128098 128360 129061 92412 107188 130346
Assignee | ||
Comment 15•22 years ago
|
||
adding dependencies for a group of open bugs that need review
Assignee | ||
Comment 16•22 years ago
|
||
adding the anchor bug as a dependency. Navigation in the help viewer is pretty well broken without link->anchors working.
Depends on: 130447
Assignee | ||
Comment 17•22 years ago
|
||
the displayIndex() function uses jan varga's iteration instead of my own clumsy go-to-a-big-number version, and the isMatch() function for checking RE's has been cleaned up (but not actually changed).
Attachment #74096 -
Attachment is obsolete: true
Assignee | ||
Comment 18•22 years ago
|
||
adding the panel-sorting bug as a dependency. Patch in that bug adjusts the attributes on the outliner for different panels.
Depends on: 131204
Comment 19•22 years ago
|
||
Looks good. Glad to see the search database. I was getting annoyed at the incoherent results that the current find returns. What's the bug to expand the contents of the search database? + // search additional search datasources + if (searchDatasources != "rdf:null") { + if (!searchDS) + searchDS = loadCompositeDS(searchDatasources); + doFindOnDatasource(resultsDS, searchDS, RDF_ROOT, 0); + } Remove the tabs there. + //outliner = document.getElementById("help-index-outliner"); + //sourceDS = outliner.database; + //if (!sourceDS) // If the index has never been displayed this will be null (sigh!). + // sourceDS = loadCompositeDS(outliner.datasources); + //doFindOnDatasource(resultsDS, sourceDS, RDF_ROOT, 0); Why is this commented out? Do you intend to uncomment it later? - if (!RE[i].test(text)) + if (!RE[i].test(text)) Unnecessary change. What is the purpose of displayIndex? The comment doesn't really tell me. Is it supposed to close all the open toplevel help topics when you go to the index, or something? If so, why? Why only those and not open children? And + var rowCount = oview.rowCount; + oview.toggleOpenState(i); + i = i + oview.rowCount - rowCount; Isn't that last statement equivalent to i = i? <button id="findButton" label="&gobtn.label;" oncommand="doFind()" flex="0"/> This should have default="true" specified.
Assignee | ||
Comment 20•22 years ago
|
||
removed tabs, redid index-opening function (and added explanation in comments), added sorting of search results (and unsorting of glossary results) from patch in 131204, which you were asking about, added default=true to find button, removed commented-out index-searching code.
Assignee | ||
Comment 21•22 years ago
|
||
Blake Thanks for looking at this! Here is a new version of the patch that includes the sorting stuff from 131204 and the fixes you describe.
Comment 22•22 years ago
|
||
Comment on attachment 75628 [details] [diff] [review] new sooperpatch based on blake's feedback sr=hewitt, contingent on fixing these nits: Don't hard-code keyCode values like 13, use the constants in KeyEvent.DOM_VK_*, see nsIDOMKeyEvent.idl If you're incrementing a variable and don't need to store the previous value, use ++i instead of i++
Attachment #75628 -
Flags: superreview+
Assignee | ||
Comment 23•22 years ago
|
||
Thanks Joe! I will put the changes you mention in. Now, Blake, if you can r=blake it, I'll get all this stuff in in time for the help system usability test that is scheduled for Thursday morning.
Assignee | ||
Comment 24•22 years ago
|
||
Comment on attachment 75628 [details] [diff] [review] new sooperpatch based on blake's feedback author=pwilson, r=oeschger. There! Hewitt's suggested fixes are in. Has review. Most of the search functionality is Peter's anyway, and he and I have been over this code a dozen times.
Attachment #75628 -
Flags: review+
Assignee | ||
Comment 25•22 years ago
|
||
Help system rdf-ified. Marking FIXED.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 26•22 years ago
|
||
Indeed it is, marking verified as of win xp build 2002041206
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•