Closed
Bug 1242965
Opened 8 years ago
Closed 8 years ago
Make services/common eslintable
Categories
(Cloud Services :: Firefox: Common, defect)
Cloud Services
Firefox: Common
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: hectorz, Assigned: hectorz)
References
Details
Attachments
(2 files)
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/32449/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/32449/
Attachment #8712164 -
Flags: review?(rnewman)
Comment 2•8 years ago
|
||
Comment on attachment 8712164 [details] MozReview Request: Bug 1242965 - Make services/common eslintable. r?rnewman https://reviewboard.mozilla.org/r/32449/#review29243 ::: services/common/async.js (Diff revision 1) > -#ifndef MERGED_COMPARTMENT I guess we don't do this any more! ::: services/common/moz.build:38 (Diff revision 1) > - EXTRA_PP_JS_MODULES['services-common'] += [ > + EXTRA_JS_MODULES['services-common'] += [ This will just go away once Bug 1237983 lands. ::: services/common/tests/unit/test_bagheera_client.js:96 (Diff revision 1) > -add_task(function test_post_delete_multiple_obsolete_documents () { > +add_task(function* test_post_delete_multiple_obsolete_documents () {
Attachment #8712164 -
Flags: review?(rnewman) → review+
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Richard Newman [:rnewman] from comment #2) > > ::: services/common/moz.build:38 > (Diff revision 1) > > - EXTRA_PP_JS_MODULES['services-common'] += [ > > + EXTRA_JS_MODULES['services-common'] += [ > > This will just go away once Bug 1237983 lands. Rebased on top of bug 1237983, carry over r+. Attach as a patch since reviewboard-hg is down.
Attachment #8713487 -
Flags: review+
Assignee | ||
Comment 4•8 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=28310e63182c
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ad188676eb21
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•