1242966 - Make services/crypto eslintable

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Comment 1

[Hector Zhao [:hectorz]]

Attachment: MozReview Request: Bug 1242966 - Make services/crypto eslintable. r?rnewman

Review commit: https://reviewboard.mozilla.org/r/32453/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32453/

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8712166 [details]
MozReview Request: Bug 1242966 - Make services/crypto eslintable. r?rnewman

https://reviewboard.mozilla.org/r/32453/#review29249

Nice.

::: services/crypto/modules/WeaveCrypto.js:10
(Diff revision 1)
> +var Cu = Components.utils;

You can change these four lines into a destructuring bind:

```
const {classes: Cc, interfaces: Ci, utils: Cu, results: Cr} = Components;
```

Comment 3

[Hector Zhao [:hectorz]]

Attachment: Patch, updated

(In reply to Richard Newman [:rnewman] from comment #2)
> 
> ::: services/crypto/modules/WeaveCrypto.js:10
> (Diff revision 1)
> > +var Cu = Components.utils;
> 
> You can change these four lines into a destructuring bind:
> 
> ```
> const {classes: Cc, interfaces: Ci, utils: Cu, results: Cr} = Components;
> ```

Done, carry over r+.

Attach as a patch since reviewboard-hg is down.

Comment 4

[Hector Zhao [:hectorz]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=28310e63182c

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/adf78202a5bb

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/adf78202a5bb