Closed
Bug 1243182
Opened 8 years ago
Closed 8 years ago
Enable eslint "space-infix-ops" rule for PSM
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: Cykesiopka, Assigned: Cykesiopka)
References
Details
Attachments
(1 file, 1 obsolete file)
32.24 KB,
patch
|
Cykesiopka
:
review+
|
Details | Diff | Splinter Review |
The rule means spaces around infix operations are required.
In other words, things like these are prevented:
> var x=0;
> a+b
This helps enforce coding style.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8716151 -
Flags: review?(dkeeler)
Comment on attachment 8716151 [details] [diff] [review] bug1243182_enable-space-infix-ops_v1.patch Review of attachment 8716151 [details] [diff] [review]: ----------------------------------------------------------------- Great! ::: security/manager/pki/resources/content/certManager.js @@ +193,5 @@ > /** > * Returns true if nothing in the given cert tree is selected or if the > * selection includes a container. Returns false otherwise. > * > + * @param {nsCertTree} certTree I imagine we still want to call this an nsICertTree, since that's the interface, right? ::: security/manager/pki/resources/content/viewCertDetails.js @@ +219,1 @@ > AddUsage(usageList[i],verifyInfoBox); Space after comma? (I guess that's another rule we'll have to enable...)
Attachment #8716151 -
Flags: review?(dkeeler) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Thanks for the review! (In reply to David Keeler [:keeler] (use needinfo?) from comment #2) > I imagine we still want to call this an nsICertTree, since that's the > interface, right? On second thought, yeah, putting the interface here makes more sense. > ::: security/manager/pki/resources/content/viewCertDetails.js > @@ +219,1 @@ > > AddUsage(usageList[i],verifyInfoBox); > > Space after comma? (I guess that's another rule we'll have to enable...) Yeah, another patch sitting in my queue. I filed Bug 1246365 for this.
Assignee | ||
Comment 4•8 years ago
|
||
+ Address nsICertTree comment
Attachment #8716151 -
Attachment is obsolete: true
Attachment #8716594 -
Flags: review+
Assignee | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa205b7be666
Keywords: checkin-needed
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/18b9f0924b4a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•