Closed
Bug 1243577
Opened 8 years ago
Closed 8 years ago
[e10s] Enable test_blob_file_backed.html with e10s
Categories
(Core :: Storage: IndexedDB, defect)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla47
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
1.47 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
1.05 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
7.06 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
This test creates a new file, which is at least the first reason it fails. One wrinkle here is that it is actually done in a file that doubles as an xpcshell unit test. Probably the way to fix this is to implement SpecialPowers.createFiles() in dom/indexedDB/test/unit/xpcshell-head-parent-process.js (where the SpecialPowers.createDOMFile() the test current uses is defined), convert the test, then delete SpecialPowers.createFiles(), which has no other users.
Updated•8 years ago
|
Blocks: e10s-tests
tracking-e10s:
--- → +
Comment 1•8 years ago
|
||
Yeah, this seems about right.
Assignee | ||
Comment 2•8 years ago
|
||
try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2aa2a7e25c6a
Attachment #8720581 -
Flags: review?(khuey)
Assignee | ||
Comment 3•8 years ago
|
||
I don't think that this matters, but I split it into a separate change set to avoid hiding it.
Attachment #8720582 -
Flags: review?(khuey)
Assignee | ||
Comment 4•8 years ago
|
||
This method is e10s-compatible. It is async, so it requires rejiggering the test a little. This also requires fixing up a shim version for xpcshell tests. Finally, this test is the only user of SpecialPowers.createDOMFiles, so I removed it.
Attachment #8720583 -
Flags: review?(khuey)
Attachment #8720581 -
Flags: review?(khuey) → review+
Comment on attachment 8720582 [details] [diff] [review] part 2 - Change file permissions to match SpecialPowers.createFiles. Review of attachment 8720582 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/indexedDB/test/unit/test_blob_file_backed.js @@ -11,5 @@ > { > const fileIOFlags = 0x02 | // PR_WRONLY > 0x08 | // PR_CREATEFILE > 0x20; // PR_TRUNCATE > - const filePerms = 0664; 664 is an odd choice ...
Attachment #8720582 -
Flags: review?(khuey) → review+
Attachment #8720583 -
Flags: review?(khuey) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d2a4d6a97d7 https://hg.mozilla.org/integration/mozilla-inbound/rev/3c13b0cab347 https://hg.mozilla.org/integration/mozilla-inbound/rev/fe5831958b30
Assignee | ||
Comment 7•8 years ago
|
||
Thanks for the reviews. I updated the 0 octal constants to 0o because somebody went through and fixed those up recently.
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2d2a4d6a97d7 https://hg.mozilla.org/mozilla-central/rev/3c13b0cab347 https://hg.mozilla.org/mozilla-central/rev/fe5831958b30
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•