Closed
Bug 1243758
Opened 8 years ago
Closed 8 years ago
Add --browser-chrome and --chunk-by-runtime flags to browser-chrome-coverage test
Categories
(Testing :: Code Coverage, defect)
Testing
Code Coverage
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: chin.bimbo, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
1.58 KB,
patch
|
chmanchester
:
review+
|
Details | Diff | Splinter Review |
This is a patch by Joel Maher to enable browser-chrome tests for browser-chrome-coverage.
Updated•8 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 8713202 [details] [diff] [review] mozharness.patch ask :chmanchester
Attachment #8713202 -
Flags: review?(cmanchester)
Comment 2•8 years ago
|
||
Comment on attachment 8713202 [details] [diff] [review] mozharness.patch Review of attachment 8713202 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the patch. Have we confirmed this does exactly what we want on try? If so just ping me and I'll get it landed.
Attachment #8713202 -
Flags: review?(cmanchester) → review+
Yes, for example we can see the generated .json files here: https://tools.taskcluster.net/task-inspector/#czDtRRwmT8uAE-5lmq7_eg/0
Comment 4•8 years ago
|
||
Trung, can you please update the commit message on this patch so I can land the patch? Thanks. Details on the commit message format can be found here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities
Flags: needinfo?(chin.bimbo)
Here is the patch with modified commit message
Attachment #8713202 -
Attachment is obsolete: true
Flags: needinfo?(chin.bimbo)
Attachment #8714468 -
Flags: review?(cmanchester)
Comment 6•8 years ago
|
||
Comment on attachment 8714468 [details] [diff] [review] c.patch Review of attachment 8714468 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! This needs "r=chmanchester" at the end to indicate the reviewer, but I'll just add that before landing. Re-requesting review in this case isn't necessary because the code hasn't changed.
Attachment #8714468 -
Flags: review?(cmanchester) → review+
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/96c92e9d6216
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•