1243758 - Add --browser-chrome and --chunk-by-runtime flags to browser-chrome-coverage test

Status: RESOLVED FIXED

(Testing :: Code Coverage, defect)

Description

[Trung Do]

Attachment: mozharness.patch

This is a patch by Joel Maher to enable browser-chrome tests for browser-chrome-coverage.

Comment 1

[Trung Do]

Comment on attachment 8713202 [details] [diff] [review]
mozharness.patch

ask :chmanchester

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8713202 [details] [diff] [review]
mozharness.patch

Review of attachment 8713202 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch. Have we confirmed this does exactly what we want on try? If so just ping me and I'll get it landed.

Comment 3

[Trung Do]

Yes, for example we can see the generated .json files here: https://tools.taskcluster.net/task-inspector/#czDtRRwmT8uAE-5lmq7_eg/0

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Trung, can you please update the commit message on this patch so I can land the patch? Thanks. Details on the commit message format can be found here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities

Comment 5

[Trung Do]

Attachment: c.patch

Here is the patch with modified commit message

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8714468 [details] [diff] [review]
c.patch

Review of attachment 8714468 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! This needs "r=chmanchester" at the end to indicate the reviewer, but I'll just add that before landing. Re-requesting review in this case isn't necessary because the code hasn't changed.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/96c92e9d6216

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/96c92e9d6216