Closed
Bug 1243928
Opened 8 years ago
Closed 8 years ago
Fix privatebrowsing browser-chrome tests in e10s
Categories
(Firefox :: Private Browsing, defect)
Firefox
Private Browsing
Tracking
()
RESOLVED
FIXED
Firefox 47
People
(Reporter: mrbkap, Assigned: mrbkap)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
16.99 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
2.87 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
The diffs aren't super useful because I unindented a bunch of stuff by switching to promises. This turned out to be pretty easy.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8713388 -
Flags: review?(felipc)
Assignee | ||
Comment 2•8 years ago
|
||
This test had DOS line endings, so every line changed :(
Attachment #8713400 -
Flags: review?(felipc)
Updated•8 years ago
|
Attachment #8713400 -
Flags: review?(felipc) → review+
Updated•8 years ago
|
Attachment #8713388 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a155b1a239df
Assignee | ||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/13d136281115950786865efe361ed48560b8a958 Bug 1243928 - Make these tests work in e10s. r=felipe
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/13d136281115
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Comment 6•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/9f88998ac4ac
status-firefox46:
--- → fixed
Comment 7•8 years ago
|
||
[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
You need to log in
before you can comment on or make changes to this bug.
Description
•