1243951 - Enable JSON Viewer for all channels

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, defect, P1)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

We currently only enable JSON Viewer for Dev. Edition.

At the very least, I think we should include Nightly.  But, why not let it ride the trains to release?

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

:clarkbw / :Honza, any thoughts one way or another?

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Yep I like that. We could start with Nightly, wait a big and continue further if there are no complaints.

Honza

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

Let's do a quick run through of the current bugs filed and assuming none are high priority I don't see a reason to keep it back.

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

Ok, here's the list of 10 bugs as it currently stands (includes this one as well so 9 really)
https://bugzilla.mozilla.org/buglist.cgi?component=Developer%20Tools%3A%20JSON%20Viewer&product=Firefox&bug_status=__open__&list_id=12824306

I'm going to use this bug as our blocker for what needs to be done to ship in production.

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

Now there are 19 since I broke down bug 1223143 into smaller pieces.

Here's my initial list:

Required
bug 1240494 - avoid AMD modules
bug 1240658 - JSON.parse error on npm registry
bug 1230583 - fixes a number of visual issues from bug 1223143
bug 1216609 - fix linkable colour
bug 1244265 - save button is broken
bug 1244268 - remove expanders on headers tab
bug 1244910 - fonts need improving
bug 1244912 - hide summary when object is expanded
bug 1244916 - hide count of empty arrays
bug 1244919 - show colon for object attributes
bug 1244920 - show object and array brackets of expanded objects

I really like but probably shouldn't block
bug 1198558 - better broken JSON support

Would be nice
bug 1217131 - filter should show complete objects, not just matches
bug 1244922 - improve search syntax
bug 1244763 - independent zoom level from page

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

I thought there as a 'linkify URLs' bug already but now I don't see it. :-(

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This is great summary Bryan!
I'll be looking at that step by step.

Honza

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

I'm probably going to block on bug 1245282 as well once we have a chance to try it out.

Comment 9

[Bryan Clark (DevTools PM) [:clarkbw]]

Metrics

Our questions are these:

# Overall
* How often do people use the JSON Viewer?
-- Understand the value of this tool compared to other tools we develop
-- release (opt-out)

# Performance (set these to expire 6 months after landing)
* How quickly are we rendering the object?
-- Understand if we're hitting large documents which are rendering slowly and need to improve our perf
-- pre-release (opt-in)

* Size of the object/file?
-- Not sure this is correct.  Trying to guess why render could be slow.
-- pre-release (opt-in)

# Features
* JSON
** Save
** Copy
* Raw
** Pretty Print
** Save
** Copy
* Headers
** Copy
* Search
-- Click counts so we can understand the most used features
-- pre-release (opt-in)

Comment 10

[Bryan Clark (DevTools PM) [:clarkbw]]

Flagging this for security review.  This code has been available on Aurora and recently Nightly but will soon ride the trains to release.  I've heard that the React library has already been reviewed for use by the Hello team.

Brief summary:
This is a viewer which renders JSON documents which are normally rendered as plain text into an HTML tool for browsing and searching the document information.  It should not be triggered by iframes.  You should be able to try out the JSON Viewer by navigating to a JSON document like this: http://live-menu.staugustinesvancouver.com/taps.json in DevEdition or a current Nightly build.

Comment 12

[Bryan Clark (DevTools PM) [:clarkbw]]

Flagging dveditz for the sec-review here.  Code is perhaps still in flux right now, want to get this on your radar.

Comment 14

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

What are we still waiting for here?

Can we just ship it? :)

Comment 15

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #14)
> What are we still waiting for here?
> 
> Can we just ship it? :)

r+

Comment 16

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1243951 - Enable JSON Viewer for all channels.

Review commit: https://reviewboard.mozilla.org/r/103012/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103012/

Comment 17

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8824561 [details]
Bug 1243951 - Enable JSON Viewer for all channels.

https://reviewboard.mozilla.org/r/103012/#review103632

LGTM

Honza

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5c3a2c6ba77
Enable JSON Viewer for all channels. r=Honza

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e5c3a2c6ba77

Comment 20

[Anselmo Canfora]

Hello, integrated JSON Viewer results in a blank page for me with large JSON outputs, I had to disable it and enable back my previous addon for JSON visualization.

Comment 21

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Anselmo Canfora from comment #20)
> Hello, integrated JSON Viewer results in a blank page for me with large JSON
> outputs, I had to disable it and enable back my previous addon for JSON
> visualization.

Please file a new bug so we can investigate this issue separately.  Thanks!

Comment 22

[Anselmo Canfora]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #21)
> (In reply to Anselmo Canfora from comment #20)
> > Hello, integrated JSON Viewer results in a blank page for me with large JSON
> > outputs, I had to disable it and enable back my previous addon for JSON
> > visualization.
> 
> Please file a new bug so we can investigate this issue separately.  Thanks!

Hi, done:

https://bugzilla.mozilla.org/show_bug.cgi?id=1358133