1243959 - [e10s] Enable browser_webconsole_autocomplete_in_debugger_stackframe.js in e10s

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: MozReview Request: Bug 1243959 - e10s fixes for browser_webconsole_autocomplete_in_debugger_stackframe.js;r=linclark

Review commit: https://reviewboard.mozilla.org/r/33539/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33539/

Comment 2

[Lin Clark [:linclark]]

Comment on attachment 8715591 [details]
MozReview Request: Bug 1243959 - e10s fixes for browser_webconsole_autocomplete_in_debugger_stackframe.js;r=linclark

https://reviewboard.mozilla.org/r/33539/#review30365

Other than the minor question, this looks good to me!

::: devtools/client/webconsole/test/browser_webconsole_autocomplete_in_debugger_stackframe.js:21
(Diff revision 1)
> +  gStackframes = null;

Is this something that should be handled in a cleanup function (so that it gets done even if the test errors out)?

Comment 3

[Brian Grinstead [:bgrins]]

(In reply to Lin Clark [:linclark] from comment #2)
> Comment on attachment 8715591 [details]
> MozReview Request: Bug 1243959 - e10s fixes for
> browser_webconsole_autocomplete_in_debugger_stackframe.js;r=linclark
> 
> https://reviewboard.mozilla.org/r/33539/#review30365
> 
> Other than the minor question, this looks good to me!
> 
> :::
> devtools/client/webconsole/test/
> browser_webconsole_autocomplete_in_debugger_stackframe.js:21
> (Diff revision 1)
> > +  gStackframes = null;
> 
> Is this something that should be handled in a cleanup function (so that it
> gets done even if the test errors out)?

Yeah I've updated it, thanks

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/bf9999a917d4

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bf9999a917d4

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7618fd997347

Comment 7

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected