1244425 - Avoid CPOW when setting file array on <input type=file>

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

Marionette passes an element reference from the content frame script to chrome space in order to gain access to element.mozSetFileArray, so users can set a file for <input type=file>.

This functionality is currently implemented in the Marionette:setElementValue message handler in GeckoDriver#sendKeysToElement: https://dxr.mozilla.org/mozilla-central/rev/d4213241bb796fdfa7a5ad4f1989e97b44474364/testing/marionette/driver.js#2208

Bug 1233497 outlaws the use of CPOWs but Marionette currently circumvents this by disabling the throwing via a preference.

We should avoid using a CPOW for this.

Comment 1

[Andreas Tolfsen ❲:ato❳]

It looks like constructing File objects in content space is now (somehow) not broken anymore:

    let file = new File(path);
    let fs = Array.prototype.slice.call(inputEl.files);
    fs.push(file);
    inputEl.mozSetFileArray(fs);

Comment 2

[Andreas Tolfsen ❲:ato❳]

Making this depend on bug 1280947 as it contains some improvements to how we call mozSetFileArray.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1244425 - Avoid CPOW when setting file array on <input type=file>;

This removes the need to use a CPOW when sending keys to <input type=file>
elements.  It was previously not possible to constructo File objects in
privileged content space, but this now appears fixed.

Review commit: https://reviewboard.mozilla.org/r/75306/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/75306/

Comment 4

[David Burns :automatedtester]

Comment on attachment 8786321 [details]
Bug 1244425 - Avoid CPOW when setting file array on <input type=file>;

https://reviewboard.mozilla.org/r/75306/#review73212

Comment 5

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8786321 [details]
Bug 1244425 - Avoid CPOW when setting file array on <input type=file>;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/75306/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c382a30453a
Avoid CPOW when setting file array on <input type=file>; r=automatedtester

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6c382a30453a

Comment 8

[Andreas Tolfsen ❲:ato❳]

Test only changes.  Depends on bug 1280947.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2984e7af1c0e

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/afd10ab995e0

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

All backed out for both for Marionette bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=1571072&repo=mozilla-beta
https://hg.mozilla.org/releases/mozilla-aurora/rev/5779143fc12d6a751fedb0b8049d52f4bd10dad9
https://hg.mozilla.org/releases/mozilla-beta/rev/462e604cb5d474ddce189a27eeb0a29242696eee

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

We are very late in beta now but could still take uplift for 50.

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

[Tracking Requested - why for this release]: Now that 50 is on the Beta channel, I would not block on this but we should consider fixing this test in Aurora 51.

Hi Andreas, David, do we plan to uplift this test fix in Aurora51?

Comment 14

[David Burns :automatedtester]

I am pretty sure the reason this failed on uplift was because of a dep which should be in all the way to beta. I will let Andreas run a test to check that we have a clean build/test of beta

Comment 15

[Andreas Tolfsen ❲:ato❳]

I’m unsure about the tracking vs. status flags on this bug:

tracking-firefox51: 	?
status-firefox51: 	fixed 

It says it’s been fixed in Firefox 51 but is not tracking.  Where do I find out what Firefox version is currently in Aurora/Beta and so on?

Comment 16

[David Burns :automatedtester]

Firefox 50 is in Beta at the moment 

Details can be found in https://wiki.mozilla.org/RapidRelease/Calendar

Comment 17

[Gerry Chang [:gchang]]

Un track 51 as it's fixed.

Comment 18

[Andreas Tolfsen ❲:ato❳]

Patch applied cleanly on beta, try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0766b9418af8

Comment 19

[Andreas Tolfsen ❲:ato❳]

Patch seems fine.  Requesting uplift again.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e9c597887c21