1244621 - Change link clicker UI favicon to Firefox Hello logo

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Comment 1

[Romain Testard [:RT]]

Sevaan can you please provide the visual asset for the Hello logo to use as Favicon?

Comment 2

[Sevaan Franks [:sevaan]]

Attachment: Hello Favicons

Comment 3

[GitHub Autolander Bot]

Attachment: [loop] mancas:bug1244621 > mozilla:master

Comment 4

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8714721 [details] [review]
[loop] mancas:bug1244621 > mozilla:master

Hey Mark, can you review this, please?

Thanks

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8714721 [details] [review]
[loop] mancas:bug1244621 > mozilla:master

I tried loading this on my mac, and on my retina display it looked reasonable, but on my non-retina it looked bad. The shadows weren't quite right.

I think since we've been given them, lets include the two new icons as well, from looking around and at (https://en.wikipedia.org/wiki/Favicon), I think changing the html to be:

    <link rel="shortcut icon" href="favicon.ico">
    <link rel="icon" type="image/png" sizes="16x16" href="favicon-16x16.png">
    <link rel="icon" type="image/png" sizes="32x32" href="favicon-32x32.png">

is probably the best option.

Comment 6

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8714721 [details] [review]
[loop] mancas:bug1244621 > mozilla:master

I've added favicons and changed the html as you suggested. Can you test it in your non-retina screen please?

Thank you

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 8714721 [details] [review]
[loop] mancas:bug1244621 > mozilla:master

Looks good. r=Standard8

Please check in with Mike & myself on irc before landing if its in the next hour or two, as we're syncing up to land other bugs at the moment.

Comment 8

[Manuel Casas Barrado [:mancas]]

Landed in master: https://github.com/mozilla/loop/commit/2679fdc299e104d96be172fd036037129cd9f79d