Closed
Bug 1244727
Opened 8 years ago
Closed 8 years ago
Remove expired histogram probes
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox47 fixed)
RESOLVED
FIXED
Firefox 47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: Margaret, Assigned: Margaret)
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/33013/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33013/
Attachment #8714317 -
Flags: review?(mark.finkle)
Comment 2•8 years ago
|
||
Comment on attachment 8714317 [details] MozReview Request: Bug 1244727 - Remove expired histogram probes. r=mfinkle https://reviewboard.mozilla.org/r/33013/#review29933 ::: mobile/android/base/java/org/mozilla/gecko/db/LocalURLMetadata.java (Diff revision 1) > - Telemetry.addToHistogram("FENNEC_TILES_CACHE_HIT", data.size()); ahunt has been in this code recently. I wonder if he has any reason to look at the existing data?
Attachment #8714317 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/cd18c8af8b56f127877aeae417139868cc96a9e5 Bug 1244727 - Remove expired histogram probes. r=mfinkle
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #2) > Comment on attachment 8714317 [details] > MozReview Request: Bug 1244727 - Remove expired histogram probes. r=mfinkle > > https://reviewboard.mozilla.org/r/33013/#review29933 > > ::: mobile/android/base/java/org/mozilla/gecko/db/LocalURLMetadata.java > (Diff revision 1) > > - Telemetry.addToHistogram("FENNEC_TILES_CACHE_HIT", data.size()); > > ahunt has been in this code recently. I wonder if he has any reason to look > at the existing data? This expired in version 40, so there won't be any recent data. We could recreate these probes if we think the data would be valuable.
Flags: needinfo?(ahunt)
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/b98399791865c79a4c8d584252dcc6f0e0853c7c Bug 1244727 - Remove expired histogram probes. r=mfinkle
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b98399791865
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Comment 7•8 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #2) > Comment on attachment 8714317 [details] > MozReview Request: Bug 1244727 - Remove expired histogram probes. r=mfinkle > > https://reviewboard.mozilla.org/r/33013/#review29933 > > ::: mobile/android/base/java/org/mozilla/gecko/db/LocalURLMetadata.java > (Diff revision 1) > > - Telemetry.addToHistogram("FENNEC_TILES_CACHE_HIT", data.size()); > > ahunt has been in this code recently. I wonder if he has any reason to look > at the existing data? My changes were just adding an extra field to the data in the cache, but caching behaviour (and the resulting data.size() ) shouldn't be affected, so I don't think there's much value for me in keeping this around.
Flags: needinfo?(ahunt)
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•