1244744 - Pointer is not visible in standalone on Chrome

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Ian Bicking (:ianbicking)]

We haven't debugged in depth, but with a Google Chrome link clicker the pointer was not visible on loop-webapp-dev.stage.mozaws.net.  No errors appeared in the console.

Comment 1

[Ed Lee :Mardak]

I wonder if this is a version of chrome issue. I'll try out locally with different versions but the video I made was with chrome Canary: https://bug1210588.bmoattachments.org/attachment.cgi?id=8714234

Comment 2

[Ed Lee :Mardak]

Just tested on

bad release Version 48.0.2564.97 (64-bit)
ok beta Version 49.0.2623.28 (64-bit)
ok canary Version 50.0.2637.0 canary (64-bit)

Not sure if it's a flag for release or it's a new feature that got introduced for 49.

Comment 3

[Ed Lee :Mardak]

This started working

bad 360786 11/20 Version 49.0.2570.0 (64-bit) b1802c0fc28635a50e7f55e40c71e69281cc85f3
ok 360804 11/20 Version 49.0.2570.0 (64-bit) b82e441c9d6975e33f35bff7c9eb9fe27b7dddc9

The relevant changes:

https://chromium.googlesource.com/chromium/src.git/+log/b1802c0fc28635a50e7f55e40c71e69281cc85f3..b82e441c9d6975e33f35bff7c9eb9fe27b7dddc9

> b82e441 Use the standard 'is_<type>' type traits by mikhail.pozdnyakov · 2 months ago
> f80fa02 Add Closure compiling instructions for site_list. by finnur · 2 months ago
> 03d7888 Adds TimeDomains to the TaskQueueManager by alexclarke · 2 months ago
> 92fdd5d Update V8 to version 4.9.29. by v8-autoroll · 2 months ago
> 2d94343 Roll WebRTC 10685:10724, Libjingle 10671:10725 by tommi · 2 months ago
> b1215f5 Update comments in Request constructor to explain referrer handling more clearly by tyoshino · 2 months ago
> a293493 A line that ends up naturally in the next column may need to propagate a strut. by mstensho · 2 months ago
> e34c4d7 Fix a style guide violation in KeyedService. by sdefresne · 2 months ago
> d90673c Add histogram config for screenshare stats. by sprang · 2 months ago
> 30d7af0 Minor cleanup in Page::unmarkAllTextMatches. by dcheng · 2 months ago
> b854092 Stop using rtc::scoped_ptr::Pass() by kwiberg · 2 months ago
> 1085193 [service worker] Remove tracing from service_worker_micro_benchmark. by falken · 2 months ago
> 3712fb1 Listbox SELECT: Fix incorrect cached selection after type-ahead selection. by tkent · 2 months ago
> 7127fde Remove ScopedVector from url_request_throttler_simulation_unittest by olli.raula · 2 months ago
> de7a5b3 bindings: Remove V8XXXOrNull::toImpl() from union containers by bashi · 2 months ago
> 57f0e5a ServiceWorker: Merge message handlers for registration association by nhiroki · 2 months ago
> 02ca4c7 Remove unused ScopedVector from net_log_util by olli.raula · 2 months ago
> 87f33f9 Support fragment URLs for more kinds of SVG images by davve · 2 months ago
> b1802c0 Switch V8HiddenValue from hidden values to privates by jochen · 2 months ago

Probably https://chromium.googlesource.com/chromium/src.git/+/2d94343e7bf3a85e123d95f6a62cdb5086eab85e
 Issue 1463003003: Roll WebRTC 10685:10724, Libjingle 10671:10725 (Closed) 

That included these webrtc changes:

https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/82cc96f..dba3e45

In any case, it looks like this will just make it to release soon.. 49	 Mar 8th, 2016 https://www.chromium.org/developers/calendar

Comment 4

[Ian Bicking (:ianbicking)]

Is there any sense what part is broken in this case?  Is the data channel simply not transferring data?

Comment 5

[Mark Banner (:standard8)]

I think this is actually:

> 87f33f9 Support fragment URLs for more kinds of SVG images by davve · 2 months ago

https://github.com/mozilla/loop/pull/131/files#diff-7ba00284fbbb86f5838b3890f73b54aeR601

That's more likely than the webrtc changes (if the data channel was broken, I'd expect more issues than just the pointer).

Comment 6

[Ed Lee :Mardak]

(In reply to Mark Banner (:standard8) from comment #5)
> > 87f33f9 Support fragment URLs for more kinds of SVG images by davve · 2 months ago
Oh nice find. Yeah looks like that's the issue. We just need to set up the svg to have the orange pointer be the default when loading cursor.svg instead of being blank. I'll put together a PR.

Comment 7

[GitHub Autolander Bot]

Attachment: [loop] Mardak:bug-1244744-chrome-pointer > mozilla:master

Comment 8

[Ed Lee :Mardak]

Attachment: screenshot of orange, blue, default

Duplicating style comments here:

use, /* Hide all use by default */
:target ~ #orange /* Hide the default (last) #orange if there's a :target */ {
  display: none;
}

#orange, /* Have #orange be shown by default */
:target /* Show the :target if there's one */ {
  display: inherit;
}

Comment 9

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8714674 [details] [review]
[loop] Mardak:bug-1244744-chrome-pointer > mozilla:master

r=me with comments addressed

Thank you!

Comment 10

[Ed Lee :Mardak]

https://github.com/mozilla/loop/commit/05a291e18889dcf41885fa2aeab4faa0e92e6ee4