1244761 - Sync preferences pane is not keyboard accessible

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Vlad Filippov (:vladikoff)]

Attachment: focus.gif

The "Disconnect" (and "Manage Account") buttons do not behave like normal buttons ("Create Account" / "Sign In" aka noFxaSignUp). I cannot target those properly with an automated tester and I guess this is also bad for accessibility reasons. 

This blocks https://github.com/mozilla/fxa/issues/104.

See attached gif for details. Let me know if there are any questions.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

The problem seems to be that we are using "click" handlers instead of "command". eg, the following patch fixes the disconnect and manage buttons:

diff --git a/browser/components/preferences/in-content/sync.js b/browser/components/preferences/in-c
ontent/sync.js
index 8d58f11..d845717 100644
--- a/browser/components/preferences/in-content/sync.js
+++ b/browser/components/preferences/in-content/sync.js
@@ -271,9 +271,9 @@ var gSyncPane = {
       gSyncPane.signIn();
       return false;
     });
-    setEventListener("verifiedManage", "click",
+    setEventListener("verifiedManage", "command",
       gSyncPane.manageFirefoxAccount);
-    setEventListener("fxaUnlinkButton", "click", function () {
+    setEventListener("fxaUnlinkButton", "command", function () {

but there are a number of other "click" handlers that look suspect (eg, the various links etc). We should fix these all at once.

Comment 2

[Vlad Filippov (:vladikoff)]

Fixed via https://github.com/mozilla/gecko-dev/commit/eb2c6cbfc2631092688aa1e7ba18d5bb0b37cc25