Closed
Bug 1244808
Opened 8 years ago
Closed 8 years ago
JavaScript Error: "calDate.jsDate is undefined" {file:[...]/calTimezoneService.js" line: 563}
Categories
(Calendar :: Internal Components, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
4.7
People
(Reporter: ssitter, Assigned: ssitter)
Details
Attachments
(1 file)
|
1.20 KB,
patch
|
Fallen
:
review+
Fallen
:
approval-calendar-aurora+
Fallen
:
approval-calendar-beta+
|
Details | Diff | Splinter Review |
The following error is reported in the log https://treeherder.mozilla.org/logviewer.html#?job_id=22848&repo=comm-aurora: JavaScript Error: "calDate.jsDate is undefined" {file:[...]/calTimezoneService.js" line: 563} jsDate was removed with Bug 1063085 and calDate.jsDate was replaced with cal.dateTimeToJsDate(calDate). But Bug 1049591 reverted the change and reintroduced calDate.jsDate.
|
Assignee | |
Comment 1•8 years ago
|
||
I'm not sure if we need this for previous branches. Error should be triggered only in new profiles when Lightning tries to guess a system timezone.
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8714421 [details] [diff] [review] obvious fix Review of attachment 8714421 [details] [diff] [review]: ----------------------------------------------------------------- Yay for bitrot! Good catch, lets push this down the branches to be sure.
Attachment #8714421 -
Flags: review?(philipp)
Attachment #8714421 -
Flags: review+
Attachment #8714421 -
Flags: approval-calendar-beta+
Attachment #8714421 -
Flags: approval-calendar-aurora+
|
||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/b2ee99e7437b https://hg.mozilla.org/releases/comm-beta/rev/f3e4a42b85af checkin-needed still for comm-central (currently closed)
|
|
||
Updated•8 years ago
|
Keywords: checkin-needed
|
|
||
Updated•8 years ago
|
Whiteboard: [checkin-needed comm-central]
Version: Lightning 4.3 → Lightning 4.6
|
||
Updated•8 years ago
|
Target Milestone: --- → 4.7
Version: Lightning 4.6 → Lightning 4.3
|
||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/945ced27efdba705d2778602fc93346ca293fe9a Bug 1244808 - Fix JavaScript Error: "calDate.jsDate is undefined" {file:[...]/calTimezoneService.js" line: 563}. r=Fallen
|
|
||
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [checkin-needed comm-central]
You need to log in
before you can comment on or make changes to this bug.
Description
•