Closed Bug 1245275 Opened 8 years ago Closed 8 years ago

Fix "Name is not a simple identifier" assertions in clang-plugin

Categories

(Developer Infrastructure :: Source Code Analysis, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: ehsan.akhgari, Unassigned)

References

Details

Attachments

(1 file)

Some methods may not have names.  NamedDecl::getName() already returns
an empty string for those, but it also asserts the consumer is asking
for something that makes sense.
Blocks: 1232038
Comment on attachment 8715001 [details] [diff] [review]
Fix "Name is not a simple identifier" assertions in clang-plugin

Review of attachment 8715001 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8715001 - Flags: review?(michael) → review+
Hmm, so this is actually wrong.  But I don't have enough time to figure out why.  ;-)  I'll close the bug and we'll keep asserting for now (this is not the only place where we assert.)
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(ehsan)
Resolution: --- → WONTFIX
Product: Core → Firefox Build System
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: