1245341 - TLS 1.3 broke the non-debug build with GCC 4.8.4

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

The NSS build, with BUILD_OPT=1, now fails thusly:

tls13con.c: In function ‘tls13_SetHsState’:
tls13con.c:153:17: error: unused variable ‘new_state_name’ [-Werror=unused-variable]
     const char *new_state_name = tls13_HandshakeState(ws);
                 ^
tls13con.c: In function ‘tls13_DeriveTrafficKeys’:
tls13con.c:1015:24: error: unused variable ‘n’ [-Werror=unused-variable]
     EXPAND_TRAFFIC_KEY(kHkdfPurposeClientWriteKey, client.write_key);
                        ^
tls13con.c:1016:24: error: unused variable ‘n’ [-Werror=unused-variable]
     EXPAND_TRAFFIC_KEY(kHkdfPurposeServerWriteKey, server.write_key);
                        ^
tls13con.c:1017:24: error: unused variable ‘n’ [-Werror=unused-variable]
     EXPAND_TRAFFIC_IV(kHkdfPurposeClientWriteIv, client.write_iv);
                        ^
tls13con.c:1018:24: error: unused variable ‘n’ [-Werror=unused-variable]
     EXPAND_TRAFFIC_IV(kHkdfPurposeServerWriteIv, server.write_iv);

From a quick look at the code, these all seem to be variables used only for assertions or debug logging.  The compiler in question:

$ gcc --version
gcc-4.8.real (Ubuntu 4.8.4-2ubuntu1~14.04) 4.8.4

Comment 1

[Eric Rescorla (:ekr)]

Attachment: 0001-Fix-opt-build-unused-variables.patch

Comment 2

[Eric Rescorla (:ekr)]

Comment on attachment 8715122 [details] [diff] [review]
0001-Fix-opt-build-unused-variables.patch

Review of attachment 8715122 [details] [diff] [review]:
-----------------------------------------------------------------

This should fix it.

Comment 3

[Eric Rescorla (:ekr)]

Jed, can you see if this fixes the problem

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8715122 [details] [diff] [review]
0001-Fix-opt-build-unused-variables.patch

Works for me.  Thanks!

Comment 5

[Eric Rescorla (:ekr)]

Committed as:
https://hg.mozilla.org/projects/nss/rev/589448c4c3d7