12455 - Problems with LDIF.pm in v1.4, memory leaks etc.

Status: RESOLVED FIXED

(Directory :: PerLDAP, defect, P3)

Description

[Leif Hedstrom]

From: Taras Dowhaluk <[e-mail]>

G'day Leif,

I've been testing 1.3.4 and was hoping to finish before you cut 1.4,
when I just saw you're post, damn and double damn.

Anyhow, there's 2 issues with printLDIF():

1. In Entry.pm, the line at 808:
          grep((print "$attr: $_\n"), @$values);
should probably be:
        if (ref($values) eq 'ARRAY') {
          grep((print "$attr: $_\n"), @$values);
        } else {
          print "$attr: $values\n";
        }
otherwise we get:
Can't use string ("blah, blah") as an ARRAY ref while "strict refs"
in use at d:/UTILS/perl/site/lib/Mozilla/LDAP/Entry.pm line 808.

2. There is a reasonable sized memory leak in LDIF.pm: put_LDIF(),
especially noticable if printfLDIF() is called within a loop, eg.

    # Loop test.
    for ($count = 0; $count <= 2000; $count++) {
        $ent = $conn->search($ld{root}, $ld{scope}, $filter);
        last unless ($ent);
       print "Loop: $count=$ent\n";
       $ent->printLDIF();
    }

A workaround is to put
    undef $record;
at the bottom of the loop at line 229.


regards, taras

Comment 1

[kristian]

I fixed these bugs in devel-branch-1_3
Entry.pm revision: 1.10.2.23
LDIF.pm  revision: 1.6.2.13