Closed
Bug 1245517
Opened 8 years ago
Closed 8 years ago
[Static Analysis][Unchecked return value] In function intrinsic_FinishBoundFunctionInit
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
DUPLICATE
of bug 1245048
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | affected |
People
(Reporter: andi, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: CID 1351131)
Attachments
(1 file)
|
1.18 KB,
patch
|
Details | Diff | Splinter Review |
The Static Analysis tool Coverity added that return value of function call: GetPrototype
>> // 9.4.1.3 BoundFunctionCreate, steps 2-3,8.
>> RootedObject proto(cx);
>> GetPrototype(cx, targetObj, &proto);
>> if (bound->getProto() != proto) {
Looking other the code in place where GetPrototype is used we can see that almost every time it's value is checked. This check is useless if the proto type of targetObj is not Lazy.
|
Reporter | |
Comment 1•8 years ago
|
||
Attachment #8715321 -
Flags: review?(jorendorff)
|
||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
|
||
Updated•8 years ago
|
Attachment #8715321 -
Flags: review?(jorendorff)
|
|
||
Updated•3 years ago
|
Assignee: bpostelnicu → nobody
You need to log in
before you can comment on or make changes to this bug.
Description
•