Closed
Bug 1245942
Opened 8 years ago
Closed 8 years ago
Update adjust docs with build instructions
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: mcomella, Unassigned)
Details
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
Details |
I forget how to build each time and waste time remembering – let's add it to the in-tree docs.
Reporter | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/33663/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33663/
Attachment #8715954 -
Flags: review?(mark.finkle)
Comment 2•8 years ago
|
||
Comment on attachment 8715954 [details] MozReview Request: Bug 1245942 - Add how to build with adjust to in-tree docs. r=mfinkle https://reviewboard.mozilla.org/r/33663/#review30349 Can we make this less anecdotal?
Attachment #8715954 -
Flags: review?(mark.finkle)
Reporter | ||
Comment 3•8 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #2) > Can we make this less anecdotal? I was unable to build without these flags before but I didn't conclusively test which ones are necessary, hence the anecdotal-quality to it. I'd rather not spend the time right now testing different configurations to find out what is necessary, thus making this less anecdotal and I'd rather land something than not and iterate – perfect is the enemy of good.
Reporter | ||
Comment 4•8 years ago
|
||
I think Nick mentioned he'd take a pass at this.
Flags: needinfo?(nalexander)
Reporter | ||
Updated•8 years ago
|
Assignee: michael.l.comella → nobody
Comment 5•8 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #4) > I think Nick mentioned he'd take a pass at this. I did, and never got to it. mcomella, a lot is changing with configure.in and confvars.sh that should make it easier to "just" add MOZ_INSTALL_TRACKING to your mozconfig. It's not there yet, but it'll happen. So I suggest either landing this (perhaps after addressing mfinkle's comment) or waiting until these configure.in changes land, clearing up the MOZ_INSTALL_TRACKING needs MOZ_NATIVE_DEVICES confusion.
Flags: needinfo?(nalexander)
Reporter | ||
Comment 6•8 years ago
|
||
(In reply to Nick Alexander :nalexander from comment #5) > So I suggest either landing this (perhaps after addressing mfinkle's > comment) or waiting until these configure.in changes land, clearing up the > MOZ_INSTALL_TRACKING needs MOZ_NATIVE_DEVICES confusion. I don't know enough of how this works and I don't think its worth investing time to find out if it's changing so that wfm.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
Assignee | ||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•