Closed Bug 1246262 Opened 8 years ago Closed 8 years ago

Fix "warning: destructor called on non-final 'Foo' that has virtual functions but non-virtual destructor"

Categories

(Core :: JavaScript: GC, defect)

Product:
Core
Component:
JavaScript: GC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox47 --- affected

People

(Reporter: terrence, Assigned: terrence)

Details

These started showing up in large volumes when I upgraded. Mostly these are CustomAutoRooters. I've been meaning to replace that infrastructure anyway, now that we can just use Rooted with basically anything.
I think this was a compiler bug: when I updated to the 3.8 release these warning went away.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
It's more likely that the compiler stopped warning when the class in question was marked final.  We've been adding final to more things lately, partly to kill off this warning, and that's probably made the difference.
You need to log in before you can comment on or make changes to this bug.