Closed
Bug 1246293
Opened 8 years ago
Closed 8 years ago
Fix a typo in DefineSelfHostedProperty
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
Details
Attachments
(1 file)
|
1.17 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
Unless I'm missing something really obtuse, we appear to always set the setter to the getter. Which I guess means that self hosted code cannot have setters at the moment?
Attachment #8716480 -
Flags: review?(till)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8716480 [details] [diff] [review] fix_DefineSelfHostedProperty_typo-v0.diff Review of attachment 8716480 [details] [diff] [review]: ----------------------------------------------------------------- Speechless.
Attachment #8716480 -
Flags: review?(till) → review+
|
Assignee | |
Comment 2•8 years ago
|
||
For the record, we counted and there are 17(!) places you'd need to update from g->s after doing a copy&paste. We could probably be organizing this code better.
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cfe34ea394c66d7fa2c6dc366b05ab00e919113 Bug 1246293 - Fix a typo in DefineSelfHostedProperty; r=till
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1cfe34ea394c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•