Closed
Bug 1246411
Opened 8 years ago
Closed 8 years ago
Lint driver.js
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox46 fixed, firefox47 fixed)
RESOLVED
FIXED
mozilla47
People
(Reporter: ato, Assigned: ato)
Details
(Keywords: pi-marionette-server)
Attachments
(4 files)
testing/marionette/driver.js has multiple issues. We should do a Spring linting.
|
Assignee | |
Updated•8 years ago
|
|
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/33901/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33901/
Attachment #8716654 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/33903/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33903/
Attachment #8716655 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/33905/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33905/
Attachment #8716656 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/33907/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33907/
Attachment #8716657 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 5•8 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5b7099206af
|
||
Updated•8 years ago
|
Attachment #8716654 -
Flags: review?(dburns) → review+
|
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8716654 [details] MozReview Request: Bug 1246411 - Yield statements must be inside generator functions; r?automatedtester https://reviewboard.mozilla.org/r/33901/#review30841
|
|
||
Comment 7•8 years ago
|
||
Comment on attachment 8716655 [details] MozReview Request: Bug 1246411 - Access to properties is better written using dot notation; r?automatedtester https://reviewboard.mozilla.org/r/33903/#review30843
Attachment #8716655 -
Flags: review?(dburns) → review+
|
|
||
Comment 8•8 years ago
|
||
Comment on attachment 8716656 [details] MozReview Request: Bug 1246411 - Remove unreachable break statements; r?automatedtester https://reviewboard.mozilla.org/r/33905/#review30845
Attachment #8716656 -
Flags: review?(dburns) → review+
|
|
||
Comment 9•8 years ago
|
||
Comment on attachment 8716657 [details] MozReview Request: Bug 1246411 - Constructors must use new keyword; r?automatedtester https://reviewboard.mozilla.org/r/33907/#review30847
Attachment #8716657 -
Flags: review?(dburns) → review+
|
||
Comment 10•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9539b0a2bf8 https://hg.mozilla.org/integration/mozilla-inbound/rev/c1abf28f3b73 https://hg.mozilla.org/integration/mozilla-inbound/rev/662bfc73887e https://hg.mozilla.org/integration/mozilla-inbound/rev/ae350a962463
|
||
Comment 11•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c9539b0a2bf8 https://hg.mozilla.org/mozilla-central/rev/c1abf28f3b73 https://hg.mozilla.org/mozilla-central/rev/662bfc73887e https://hg.mozilla.org/mozilla-central/rev/ae350a962463
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
|
|
||
Comment 12•8 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-aurora/rev/ebe0432714c2 https://hg.mozilla.org/releases/mozilla-aurora/rev/f4573e0f8384 https://hg.mozilla.org/releases/mozilla-aurora/rev/12bb924f66cd
status-firefox46:
--- → fixed
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•