1246451 - [e10s] dom/push/test/test_permissions.html | {"action":1,"state":"granted"} - got "denied", expected "granted"

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Jonathan Griffin (:jgriffin)]

On Windows 7, mochitest-push in e10s mode is permafail with:

15 INFO TEST-UNEXPECTED-FAIL | dom/push/test/test_permissions.html | {"action":1,"state":"granted"} - got "denied", expected "granted"
17 INFO TEST-UNEXPECTED-FAIL | dom/push/test/test_permissions.html | {"action":3,"state":"prompt"} - got "denied", expected "prompt"
18 INFO TEST-UNEXPECTED-FAIL | dom/push/test/test_permissions.html | {"action":0,"state":"prompt"} - got "denied", expected "prompt" 

log: https://treeherder.mozilla.org/logviewer.html#?job_id=16372051&repo=try

Comment 1

[Lina Butler [:lina]]

Hmm, I've seen this fail on OS X with `mach mochitest --e10s`, too. I thought the `SpecialPowers.pushPermissions` wrapper from bug 1191931 would've helped, but apparently not.

Is this all I need to run mochitest-push under e10s? https://hg.mozilla.org/try/rev/6fe342dcb884

Comment 2

[Jonathan Griffin (:jgriffin)]

(In reply to Kit Cambridge [:kitcambridge] from comment #1)
> Hmm, I've seen this fail on OS X with `mach mochitest --e10s`, too. I
> thought the `SpecialPowers.pushPermissions` wrapper from bug 1191931
> would've helped, but apparently not.
> 
> Is this all I need to run mochitest-push under e10s?
> https://hg.mozilla.org/try/rev/6fe342dcb884

Yes, that's all that's needed.

Comment 3

[Lina Butler [:lina]]

Looks like it's green now:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0ec9e74fd06&exclusion_profile=false

Comment 4

[Jonathan Griffin (:jgriffin)]

(In reply to Kit Cambridge [:kitcambridge] from comment #3)
> Looks like it's green now:
> 
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=b0ec9e74fd06&exclusion_profile=false

No, that's the non-e10s version. The e10s version is still broken.

Comment 5

[Lina Butler [:lina]]

Sorry about that. I changed `win_unittest.py` in https://hg.mozilla.org/try/rev/b0ec9e74fd06; what else do I need to do to run the e10s version?

Comment 6

[Jonathan Griffin (:jgriffin)]

(In reply to Kit Cambridge [:kitcambridge] from comment #5)
> Sorry about that. I changed `win_unittest.py` in
> https://hg.mozilla.org/try/rev/b0ec9e74fd06; what else do I need to do to
> run the e10s version?

My bad, you did the right thing!