1246526 - Cannot close dev tools in WebIDE while connected to safari on iOS.

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Off By None]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160206030207

Steps to reproduce:

Only happens with e10s on

Connect to safari on iOS (I believe it was consistently failing across multiple pages) I was using and iPad on I believe 9.1
Open the dev tools
Try to close the dev tools by hitting the x in the upper right of the tools.

I was running win 8.1x64 current Nightly.


Actual results:

Dev tools did not close. I also got the below error in the browser console:

Panel webconsole: TypeError: panel is undefined
Stack trace:
Toolbox.prototype.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/framework/toolbox.js:1996:9
EventListener.handleEvent*Toolbox.prototype.open/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/framework/toolbox.js:379:7
TaskImpl_run@resource://gre/modules/Task.jsm:319:40
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:11
this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:779:7
this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:714:7
attachThread/handleResponse/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/framework/attach-thread.js:75:7
DebuggerClient.requester/</<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/client/main.js:294:9
exports.makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:101:14
emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9
emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38
Request.prototype.emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/client/main.js:1232:29
DebuggerClient.prototype.onPacket/emitReply@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/client/main.js:1016:29
DevTools RDP*DebuggerClient.prototype.request@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/client/main.js:722:5
DebuggerClient.requester/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/client/main.js:282:12
exports.makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:101:14
ThreadClient.prototype.resume@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/client/main.js:1751:12
attachThread/handleResponse@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/framework/attach-thread.js:64:5
TabClient.prototype.attachThread/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/client/main.js:1291:7
resolve@resource://devtools/shared/deprecated-sync-thenables.js:40:40
then@resource://devtools/shared/deprecated-sync-thenables.js:20:43
resolve@resource://devtools/shared/deprecated-sync-thenables.js:72:11
listenerJson@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/client/main.js:738:9
emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9
emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38
Request.prototype.emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/client/main.js:1232:29
DebuggerClient.prototype.onPacket/emitReply@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/client/main.js:1016:29
DevTools RDP*DebuggerClient.prototype.request@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/client/main.js:722:5
TabClient.prototype.attachThread@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/client/main.js:1286:12
attachThread@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/framework/attach-thread.js:86:5
1 toolbox.js:1999


Expected results:

Dev tools should have closed.

Comment 1

[Off By None]

Looks like jryans fix for bug 1246522 fixed this as well.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Great!

https://github.com/mozilla/valence/commit/e5ec89ad3e8eda253c798eb803b2bda4562f9dea