Closed
Bug 1247327
Opened 8 years ago
Closed 8 years ago
Add WebGL acceptance rates to telemetry
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla47
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
(Blocks 1 open bug)
Details
(Whiteboard: gfx-noted)
Attachments
(1 file, 1 obsolete file)
2.51 KB,
patch
|
milan
:
review+
lizzard
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8718001 -
Flags: review?(vladan.bugzilla)
Updated•8 years ago
|
Whiteboard: gfx-noted
Assignee | ||
Comment 3•8 years ago
|
||
Vladan reviewed this in person. - What are the questions that these probes are designed to address? How many people are not getting WebGL - Is this the minimum amount of data necessary to answer those questions? Yes - Who is responsible for monitoring the data? The GFX team/Me - How often will they do it? Maybe once a quarter - Do the necessary monitoring dashboards already exist or who is going to create them? Not yet, but it should be easy to add to dvander's telemetry stuff - What's the user value? Hopefully more people will WebGL
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1fb660fde013
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Feels like there is overlap between CANVAS_WEBGL_USED and CANVAS_WEBGL_SUCCESS. I'm not sure we need CANVAS_WEBGL_USED anymore, since the existence of either value in CANVAS_WEBGL_SUCCESS would suggest we were trying to use it. Also, does it make sense to combine the WebGL1 and WebGL2 and just have an integer histogram that captures all of these? WebGL1-Failed, WebGL1-Succeeded, WebGL2-Failed, WebGL2-Succeeded - a single histogram with four values instead of three histograms?
Flags: needinfo?(jmuizelaar)
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8718001 [details] [diff] [review] Track whether webgl context creation succeeds Review of attachment 8718001 [details] [diff] [review]: ----------------------------------------------------------------- I'd like to get this on aurora/beta so that we can gather data sooner without waiting.
Attachment #8718001 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8718001 [details] [diff] [review] Track whether webgl context creation succeeds Approval Request Comment [Feature/regressing bug #]: None [User impact if declined]: None [Describe test coverage new/current, TreeHerder]: None [Risks and why]: Just adds telemetry
Flags: needinfo?(jmuizelaar)
Attachment #8718001 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 8•8 years ago
|
||
I'll make another patch that removes CANVAS_WEBGL_USED
Flags: needinfo?(jmuizelaar)
Updated•8 years ago
|
Comment 9•8 years ago
|
||
Comment on attachment 8718001 [details] [diff] [review] Track whether webgl context creation succeeds Too late for 45.
Attachment #8718001 -
Flags: approval-mozilla-beta?
Attachment #8718001 -
Flags: approval-mozilla-beta-
Attachment #8718001 -
Flags: approval-mozilla-aurora?
Attachment #8718001 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 10•8 years ago
|
||
Comment on attachment 8718001 [details] [diff] [review] Track whether webgl context creation succeeds Review of attachment 8718001 [details] [diff] [review]: ----------------------------------------------------------------- I looked at the telemetry results for this patch and it turns out the patch is garbage.
Attachment #8718001 -
Flags: approval-mozilla-aurora+ → approval-mozilla-aurora-
Assignee | ||
Comment 11•8 years ago
|
||
Attachment #8718001 -
Attachment is obsolete: true
Attachment #8718001 -
Flags: review?(vladan.bugzilla)
Flags: needinfo?(jmuizelaar)
Attachment #8724956 -
Flags: review?(milan)
Assignee | ||
Updated•8 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•8 years ago
|
Attachment #8724956 -
Flags: review?(milan) → review+
Comment 13•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/863c6740f637
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
Comment 14•8 years ago
|
||
Looks great! Jeff, once we've got a bit more data on this, could you post them my way? Or if the data is public, can I visit a page to track it manually?
Flags: needinfo?(jmuizelaar)
Assignee | ||
Comment 15•8 years ago
|
||
Comment on attachment 8724956 [details] [diff] [review] Try for more success with counting this Approval Request Comment [Feature/regressing bug #]: None [User impact if declined]: We'll have less visibility into WebGL success rates. [Describe test coverage new/current, TreeHerder]: The data seems to be showing up correctly on telemetry.mozilla.com [Risks and why]: Low risk as it's just a telemetry addition.
Flags: needinfo?(jmuizelaar)
Attachment #8724956 -
Flags: approval-mozilla-aurora?
Comment on attachment 8724956 [details] [diff] [review] Try for more success with counting this This is already in Aurora47, I believe the request was to uplift to 46 (Beta). Flipping the uplift flag to reflect that.
Attachment #8724956 -
Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Comment 17•8 years ago
|
||
Comment on attachment 8724956 [details] [diff] [review] Try for more success with counting this Since Jeff says this now gives the correct data (in 47/48) let's uplift this for beta 4.
Attachment #8724956 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 19•8 years ago
|
||
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #17) > Comment on attachment 8724956 [details] [diff] [review] > Try for more success with counting this > > Since Jeff says this now gives the correct data (in 47/48) let's uplift this > for beta 4. backed out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=923464&repo=mozilla-beta
Flags: needinfo?(jmuizelaar)
Comment 20•8 years ago
|
||
Jeff do you want to try this again ? I am aiming to start the beta 4 build early this afternoon. So we could still get it in if you can successfully land it. Or, wontfix for beta.
Comment 21•8 years ago
|
||
We can still land this in beta 5 which will gtb on Thursday.
Comment 22•8 years ago
|
||
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #21) > We can still land this in beta 5 which will gtb on Thursday. this is in risk missing beta 5 :(
Assignee | ||
Comment 24•8 years ago
|
||
Crap. I forgot to land... I'll do it now.
Flags: needinfo?(milan)
Flags: needinfo?(jmuizelaar)
Comment 25•8 years ago
|
||
Jeff landed this. https://hg.mozilla.org/releases/mozilla-beta/rev/077b2fd8626d
You need to log in
before you can comment on or make changes to this bug.
Description
•