1247493 - Implement the `tabId` property of browser.windows.create

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Comment 1

[Kris Maglione [:kmag]]

Attachment: MozReview Request: Bug 1247493: [webext] Implement the `tabId` property of windows.create. r?billm

Review commit: https://reviewboard.mozilla.org/r/34631/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34631/

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8718584 [details]
MozReview Request: Bug 1247493: [webext] Implement the `tabId` property of windows.create. r?billm

https://reviewboard.mozilla.org/r/34631/#review31833

::: browser/components/extensions/ext-windows.js:78
(Diff revision 1)
> +          if (createData.incognito !== null) {

If this is in agreement with the tab's incognito status, I feel like we shouldn't reject. Do you know what Chrome does?

Comment 3

[Kris Maglione [:kmag]]

https://reviewboard.mozilla.org/r/34631/#review31833

> If this is in agreement with the tab's incognito status, I feel like we shouldn't reject. Do you know what Chrome does?

Yeah, I thought about that. I don't really have a strong opinion on it, but I'd prefer that people not specify it when moving tabs.

That said, Chrome allows creating a new incognito window with a non-incognito tab, or vise versa, but the tabs keep their previous `incognito` property. I don't think we should try to do the same. We have a few tests to prevent dragging tabs from one window type to another, and it seems like the correct behavior.

Chrome also doesn't take the type of the tab's current window into account when creating that window, though, so add-ons would need to pass `{ incognito: tab.incognito }` to do it correctly there. So I guess we should allow it as well.

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/fx-team/rev/cf766413a25e77d31495f2b6e7d38e1d1bb40603
Bug 1247493: [webext] Implement the `tabId` property of windows.create. r=billm

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out because either it or one of the other patches pushed together broke some tests: https://treeherder.mozilla.org/logviewer.html#?job_id=7363470&repo=fx-team

https://hg.mozilla.org/integration/fx-team/rev/2a46feffefcc

Comment 6

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/fx-team/rev/edeaf23bea8655f3b03612bf8743edd8c592a263
Bug 1247493: [webext] Implement the `tabId` property of windows.create. r=billm

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/edeaf23bea86