1248450 - Pass graphics error messages to the parent so that we see them in about:support

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

See bug 1247539 comment 1.  gfxCriticalError/Note and equivalent show up in about:support, but only when sent from the parent process.  When sent from the content process, they're not available to the API we have.

Crash reports should already be fine.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: MozReview Request: Bug 1248450: Send the graphics messages to the parent process. r=dvander

Review commit: https://reviewboard.mozilla.org/r/34999/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34999/

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8719552 [details]
MozReview Request: Bug 1248450: Send the graphics messages to the parent process. r=dvander

https://reviewboard.mozilla.org/r/34999/#review31623

::: dom/ipc/PContent.ipdl:1020
(Diff revision 1)
> +    sync GraphicsError(nsCString aError);

This should be async, unless there's a specific ordering problem you had in mind.

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to David Anderson [:dvander] from comment #2)
> ...
> 
> This should be async, unless there's a specific ordering problem you had in
> mind.

I kept thinking in the context of crashes, but, you're right, this is just for about:support, so it can wait.

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8719552 [details]
MozReview Request: Bug 1248450: Send the graphics messages to the parent process. r=dvander

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/34999/diff/1-2/

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8719552 [details]
MozReview Request: Bug 1248450: Send the graphics messages to the parent process. r=dvander

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/34999/diff/2-3/

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/22d0921df35a

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/22d0921df35a