1248543 - Need to release decoder resources for dom/media/test/crashtests

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

Run |./mach crashtest dom/media/test/crashtests/ --run-until-failure --repeat 10000| and soon you will see the following error messages:

[26928] WARNING: AudioStream::OpenCubeb() 7f631b9fad40 failed to init cubeb
[26928] WARNING: Decoder=7f6301aef400 Decode error, changed state to ERROR

This is because too many cubeb streams are opened and not released when tests finish. 495794-1.html times out because of failing to open a cubeb stream to start playback.

This is also responsible for the OOM in bug 1242774 comment 27.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f97d06da2e0

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1248543 - release decoder resources when finishing tests to avoid OOM and failing to open cubeb streams. r=kinetik.

Review commit: https://reviewboard.mozilla.org/r/35095/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35095/

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 8719762 [details]
MozReview Request: Bug 1248543 - release decoder resources when finishing tests to avoid OOM and failing to open cubeb streams. r=kinetik.

https://reviewboard.mozilla.org/r/35095/#review31787

Please add a comment explaining what resetting src does, so anyone creating or copying a test keeps that behaviour, and to make it easier to clean up the tests once we have better audio stream resource management.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review! I will add comments to explain the purpose of resetting 'src'.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d9af8eaf17f

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0d9af8eaf17f