Closed
Bug 1248693
Opened 8 years ago
Closed 8 years ago
install.rdf addon version is wrong
Categories
(Firefox :: Pocket, defect)
Tracking
()
RESOLVED
FIXED
Firefox 47
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
References
Details
Attachments
(1 file)
1010 bytes,
patch
|
Gijs
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
It currently uses the firefox version for the addon version. This should be different to allow the potential for future out of band updates to the addon.
Assignee | ||
Comment 1•8 years ago
|
||
[Tracking Requested - why for this release]: see comment 0
Blocks: 1215694
tracking-firefox46:
--- → ?
Comment 2•8 years ago
|
||
Tracking for 46 since this is feature related work aimed at 46. Thanks Shane!
Assignee | ||
Comment 3•8 years ago
|
||
Assignee: nobody → mixedpuppy
Attachment #8719899 -
Flags: review?(gijskruitbosch+bugs)
Updated•8 years ago
|
Attachment #8719899 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/99b0afb72e77f3a494f9cc4d0cdf14d81a3b39e8 Bug 1248693 fix pocket addon version, r=gijs
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/99b0afb72e77
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8719899 [details] [diff] [review] fix addon version Approval Request Comment [Feature/regressing bug #]:pocket [User impact if declined]:incorrect version would affect out of band updates if they were to happen [Describe test coverage new/current, TreeHerder]:none [Risks and why]: low [String/UUID change made/needed]:none
Attachment #8719899 -
Flags: approval-mozilla-aurora?
Comment 7•8 years ago
|
||
Comment on attachment 8719899 [details] [diff] [review] fix addon version Needed for pocket to work as system addon in 46. Please uplift to aurora.
Attachment #8719899 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 8•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/7b25880b56ef
Comment 9•8 years ago
|
||
[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
You need to log in
before you can comment on or make changes to this bug.
Description
•