1248853 - Provide options for users to view URL on TV Web Apps listings

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

Description

[Joe Cheng [:jcheng] (please needinfo)]

base on latest discussion with various groups, we should add an option for users to "view URL" on TV Web Apps listings

Comment 1

[Michael Ellis]

+1 for Tori's Option # 3 - "Place URL inside option menu"

I think this approach would be best, given the URLs we have today. For illustration, here is an example of two of our current content URLs:

Cliggo - http://music-dev.cliggo.com/includes/app_specials/tv/?device=mobile&tv=panasonic
Bust A Move - http://d3divlwnjap65x.cloudfront.net/

Comment 2

[Josh Cheng [:josh]]

Tori,

Comment 3

[Josh Cheng [:josh]]

Hi Tori,
Could you update the UX spec to reflect this so Joseph can work on that?
Thanks

Comment 4

[Tori Chen [:tori]]

Please check the updated spec here (v2.3 p26~27)
https://drive.google.com/open?id=0B4dMhI4hp32OWllCWHBkQXlnbFE

Comment 5

[Tori Chen [:tori]]

Comments from previous discussion in email thread for record

proposals
https://docs.google.com/a/mozilla.com/presentation/d/18GKw5fc6Z3tvqdSNerGPnYHe-ZaLNqBK6zNT5h0sftk/edit?usp=sharing

Joe: #3 looks good, like what we discussed in the morning

Michael: +1 for Option 3 - "Place URL in option menu"

Elvin:  For the interim, the URL should be 'visible' to users, but we should process that URL as we would in any other context. Longer term something like Option 1 or 2 would be preferred as it makes most clear who is responsible for the content and sets users expectations right off the bat.

Comment 6

[Evelyn Hung]

Joseph, please checkout this spec and see if there is any missing piece. Question: for hosted app, do we know their launch URL in manifest from server side?

Comment 7

[Joseph Yeh [:joseph]]

Yes, api will give us the url of the hosted app.

However, in the spec p26, I'm not sure if we can change the text of ok button in a native confirm dialog. Or should this be handled by the system app?

Comment 8

[Joseph Yeh [:joseph]]

After discussion with Luke and Ricky, it seems to be more appropriate to handled by the system app.

Comment 9

[Josh Cheng [:josh]]

Ricky,
Please help this, this is priority 1. Thanks

Comment 10

[Ricky Chien [:rickychien] (inactive)]

After offline discussion, I will be a mentor for this issue helping mentee work on smart-system part.

Comment 11

[Josh Cheng [:josh]]

Hi Evelyn,
PLease help assign developer on this bug. Thanks

Comment 12

[Evelyn Hung]

Let's take option 3.
@tori, please provide your UX spec here, so Joseph can start working on it. Thanks!

Comment 13

[Tori Chen [:tori]]

Here is the latest ux spec (V2.5, p26.27), thanks!
https://drive.google.com/open?id=0B4dMhI4hp32OWllCWHBkQXlnbFE

Comment 14

[Joseph Yeh [:joseph]]

Attachment: jostw:josyeh/Marketplace/master/Bug1248853 > mozilla-b2g:master

Comment 15

[GitHub Autolander Bot]

Attachment: [gaia] jostw:josyeh/Marketplace/master/Bug1248853 > mozilla-b2g:master

Comment 16

[Joseph Yeh [:joseph]]

Comment on attachment 8726032 [details] [review]
[gaia] jostw:josyeh/Marketplace/master/Bug1248853 > mozilla-b2g:master

Hi Luke, this patch will add a context menu to show the link of the website. Please take a look at it, thanks!

Comment 17

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8726032 [details] [review]
[gaia] jostw:josyeh/Marketplace/master/Bug1248853 > mozilla-b2g:master

Nice work!

Comment 18

[Joseph Yeh [:joseph]]

Landed in gaia master.

https://github.com/mozilla-b2g/gaia/commit/f41e046a5c6032d9ce281fdb96256be7fc9b0c0f

Comment 19

[Joseph Yeh [:joseph]]

Comment on attachment 8726032 [details] [review]
[gaia] jostw:josyeh/Marketplace/master/Bug1248853 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):1248853
[User impact] if declined: cannot see url of the website
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: Yes

Comment 20

[Josh Cheng [:josh]]

Comment on attachment 8726032 [details] [review]
[gaia] jostw:josyeh/Marketplace/master/Bug1248853 > mozilla-b2g:master

Approve for TV 2.5

Comment 21

[Mike Lien[:mlien]]

Test cases added: https://moztrap.mozilla.org/manage/cases/?&pagenumber=1&pagesize=100&sortfield=created_on&sortdirection=desc&filter-id=18001&filter-id=18003

Comment 22

[GitHub Autolander Bot]

Attachment: [gaia] jostw:v2.5 > mozilla-b2g:v2.5

Comment 23

[Joseph Yeh [:joseph]]

Uplift to gaia v2.5

https://github.com/mozilla-b2g/gaia/commit/07fc590a0a13f35420330d3d51c903cac7ba1208

Comment 24

[cindylee]

Verified this issue on v2.5 and v2.6 latest build and the result is PASS.

[Build Info]
2.5 TV Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/07fc590a0a13f35420330d3d51c903cac7ba1208
gecko:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/55524f2fac552f8e3074bcf220a2d138f4ea3201
mulet:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3 

2.6 TV Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/ae8fe4552de265860970162f1d199ec6326fc51d
gecko:
https://hg.mozilla.org/mozilla-central/rev/5a2e0878d6c258b36b0ee8712a2afcde6ad94c78