1248860 - Baldr: change function bodies to an expr list from expr

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

The AST has function bodies being an expr list:
  https://github.com/WebAssembly/spec/blob/master/ml-proto/spec/ast.ml#L207
but currently they're just an expr.

Comment 1

[Luke Wagner [:luke]]

Attachment: mv-compile-args

This is convenient for the next patch and avoids the ad hoc passing of CompileArgs.

Comment 2

[Luke Wagner [:luke]]

Attachment: rm-interrupt-check

This patch removes the non-wasm interrupt opcodes so we don't have to worry about them in the next patch.

Comment 3

[Luke Wagner [:luke]]

Attachment: body-is-a-list

You may recognize parts of this patch :)  Note that this time the body is an 'expr list' which is almost like a block but no Expr::Block opcode.

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8720134 [details] [diff] [review]
rm-interrupt-check

Review of attachment 8720134 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/185f8e002c0e
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4d7e7b3172f
https://hg.mozilla.org/integration/mozilla-inbound/rev/6bb9aa94a48e

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/185f8e002c0e
https://hg.mozilla.org/mozilla-central/rev/c4d7e7b3172f
https://hg.mozilla.org/mozilla-central/rev/6bb9aa94a48e