Closed
Bug 1249275
Opened 8 years ago
Closed 8 years ago
Compilation is broken on mac if sandbox is disabled
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: jya, Assigned: jya)
References
Details
(Keywords: regression)
Attachments
(1 file)
With options: ac_add_options --disable-sandbox ac_add_options --disable-content-sandbox 17:16.45 In file included from /Users/jyavenard/Work/Mozilla/obj-ff-dbg/dom/media/gmp/Unified_cpp_dom_media_gmp0.cpp:29: 17:16.47 /Users/jyavenard/Work/Mozilla/mozilla-central/dom/media/gmp/GMPChild.cpp:354:8: error: no matching function for call to 'GetPluginFile' 17:16.47 if (!GetPluginFile(mPluginPath, libFile)) { 17:16.47 ^~~~~~~~~~~~~ 17:16.47 /Users/jyavenard/Work/Mozilla/mozilla-central/dom/media/gmp/GMPChild.cpp:110:1: note: candidate function not viable: requires 3 arguments, but 2 were provided 17:16.47 GetPluginFile(const nsAString& aPluginPath, 17:16.47 ^ 17:25.63 MediaStreamList.o 17:26.92 1 error generated. 17:26.96 regressions appear to have been introduced by changes bug 1246835
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(gsquelart)
Flags: needinfo?(cpearce)
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/35471/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/35471/
Attachment #8720787 -
Flags: review?(gsquelart)
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(gsquelart)
Flags: needinfo?(cpearce)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jyavenard
Comment on attachment 8720787 [details] MozReview Request: Bug 1249275: Fix mac compilation when sandbox is disabled. r?gerald https://reviewboard.mozilla.org/r/35471/#review32185 Good catch, thank you.
Attachment #8720787 -
Flags: review?(gsquelart) → review+
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4cba1f83f797
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•