1249746 - Login UI hiccups caused by redisplaying list unnecessarily

Status: RESOLVED WORKSFORME

(Firefox for iOS :: Login Management, defect, P3)

Description

[Ryan Feeley [:rfeeley]]

Attachment: loading.png

Return to the list from a login is too slow to load. Looks like web content.

Comment 1

[Stephan Leroux [:sleroux]]

Is there a neat test profile I can use for profiling this?

Comment 2

[Richard Newman [:rnewman]]

I don't have one, but Kevin or Aaron might have a test FxA you can sign in to. Failing that, synthesize 400 with random domains and usernames…

Comment 3

[Justin D'Arcangelo [:justindarc]]

Simon, can you find the limitations to where this list becomes slow? (e.g. 500, 1000)

Comment 4

[Justin D'Arcangelo [:justindarc]]

Assigning to myself. We need a script to generate a bunch of fake logins to perf test.

Comment 5

[Richard Newman [:rnewman]]

Even without a script to generate test data, it's probably worth verifying with EXPLAIN that both branches of the UNION ALL are making use of the two indices we have for that table.

(Beyond that, it'd be nice if we didn't construct a Login for every row of the table view… darn OO.)

Comment 6

[Richard Newman [:rnewman]]

I have 750 saved logins, and on a 6S the list loads fast enough that the only delay is a visual hiccup when adding and removing the spinner! Ryan, is this still bad for you?

Comment 7

[Ryan Feeley [:rfeeley]]

Loads fast for me now. The only hiccup I see if when I tap in and out of the search box.

Comment 8

[Richard Newman [:rnewman]]

Morphing the bug to be "be smoove".

Comment 9

[:garvan]

The logins backend and front-end have been rewritten and we aren't seeing this bug.