1249830 - Multiple runtime.onMessage listeners unable to respond

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect, P2)

Description

[Marc]

Attachment: Simple WebExtension showing onMessage response issue.

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.28 Safari/537.36

Steps to reproduce:

I have two runtime.onMessage listeners, each needing the capability to respond inline via their "sendResponse" parameters.

Under Chrome, both do respond, under Firefox only the first instance does.

I'm attaching a simple WebExtension that shows the issue more clearly.


Actual results:

Only the first instance of runtime.onMessage.addListener() responds, the rest are silent.


Expected results:

All instances of runtime.onMessage.addListener() should be able to respond.  Agreed that only one can respond *at a time*, but that's up to the developer ;).

Comment 1

[Kris Maglione [:kmag]]

Luca, have you already started on this?

I didn't realize it was already assigned, but I was planning to work on it.

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Kris Maglione [:kmag] from comment #1)
> Luca, have you already started on this?
> 
> I didn't realize it was already assigned, but I was planning to work on it.

I started to look into it around the end of the week (starting by exploring the components which provide the features and evaluating how far they were from the changes applied elsewhere in out WebExtensions internals).

No worries (I had the feeling that it could probably start to overlap a bit with Bug 1248497, which you were already working on).

Comment 3

[Kris Maglione [:kmag]]

Thanks

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/mozilla-central/rev/557e8160f351

Comment 5

[Marc]

In 47.0a2 (2016-03-11) this does not appear to be fixed :(.

In the test extension above, only one message gets received by the content script, not two.

Comment 6

[Kris Maglione [:kmag]]

This landed in Firefox 48. The fix isn't present in 47.

Comment 7

[Marc]

Oh, I see.  Sorry about that.  Unfortunately this means I'll have to wait another 6 weeks to further test my extension.

Comment 8

[Kris Maglione [:kmag]]

You should be able to test it on 48. In any case, I plan to request uplift to 47 next week, so you shouldn't have to wait an entire 6 weeks for this to land on Aurora.

Comment 9

[Marc]

That would be great, thanks ;).

Comment 10

[Vasilica Tamas, QA [:vtamas]]

Is there any proper way of manually testing this bug?

Comment 11

[Kris Maglione [:kmag]]

In this case, I think the unit tests should be enough.