1249857 - mach artifact output and cache clearing bug fixes

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

Patches to fix minor bugs coming.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1249857 - Do not print times when running mach from config.status; r?nalexander

Currently, config.status runs `mach artifact install`. mach commands prefix
output lines with elapsed time by default. When running from `mach build`,
there will be 2 sets of times in `mach artifact install` output lines.
When config.status is run directly, there will be no times printed
except for `mach artifact install`. It is weird both ways.

Fix it by not printing lines when running `mach artifact install` from
config.status.

Review commit: https://reviewboard.mozilla.org/r/35733/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35733/

Comment 2

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1249857 - Reference proper cache attribute; r?nalexander

self._pushhead_cache no longer exists. But self._tree_cache does!

This was causing AttributeError when running `mach artifact clear-cache`
and other misc `mach artifact` sub-commands.

Review commit: https://reviewboard.mozilla.org/r/35735/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35735/

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8721594 [details]
MozReview Request: Bug 1249857 - Do not print times when running mach from config.status; r?nalexander

https://reviewboard.mozilla.org/r/35733/#review32403

Aye sir!

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8721595 [details]
MozReview Request: Bug 1249857 - Reference proper cache attribute; r?nalexander

https://reviewboard.mozilla.org/r/35735/#review32405

::: python/mozbuild/mozbuild/artifacts.py:213
(Diff revision 1)
> +        import concurrent.futures as futures

This used to be broken on some less-popular architecture.  Is that no longer true?

::: python/mozbuild/mozbuild/artifacts.py:881
(Diff revision 1)
> -        self._pushhead_cache.print_last()
> +        self._tree_cache.print_last()

Thanks -- I had this fixed in a local branch and never pushed it upstream.

Comment 5

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/35735/#review32405

> This used to be broken on some less-popular architecture.  Is that no longer true?

Are you thinking of multiprocessing? Either way, I uploaded a commit with unintended changes added. I'll remove this before landing.

Comment 6

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dca1b06710dd69690fb8e50d9f38825367ea077e
Bug 1249857 - Do not print times when running mach from config.status; r=nalexander

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0d2ffb04e8efd75a2a5b2bcb37faf330c2b269b
Bug 1249857 - Reference proper cache attribute; r=nalexander

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/dca1b06710dd
https://hg.mozilla.org/mozilla-central/rev/c0d2ffb04e8e