1249884 - Re-opening a saved paintext draft inserts a <div moz-forward-container>, regression from bug 736584

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Jorg K (CEST = GMT+2)]

Re-opening a saved paintext draft inserts a <div moz-forward-container>, regression from bug 736584.

Sorry about that. There is an
  if (isForwarded) {
missing in the plaintext processing.

I'll submit a patch in the next few hours.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: adding the missing if (isForwarded)

So sorry about this omission. I went to a Mozilla policy meeting today and on the subway it occurred to me that in the HTML part there was an "if (isForwarded) {" which was missing from the plaintext part.

So I tried the plaintext, and sure enough, re-opening a saved plaintext draft runs through the same processing in adds the container which we don't want. The user doesn't notice it unless they inspect the DOM, but anyway, it needs to be fixed.

Sadly the patch looks large, but all it is is adding "if (isForwarded) {}" twice and changing the indentation.

BTW: I've seen Mozreview in action and is doesn't flag blocks whose indentation has changed.

Sorry again for the extra hassle.

Comment 2

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/55cda620d5fd

Note TB 45 is only affected if bug 736584 is approved for beta as requested.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8721697 [details] [diff] [review]
adding the missing if (isForwarded)

[Approval Request Comment]
Regression caused by (bug #): Bug 736584
Risk to taking this patch (and alternatives if risky):
If bug 736584 is accepted into beta, this needs to go too since it represents a two line amendment.

Comment 4

[Jorg K (CEST = GMT+2)]

Aurora (TB 46):
https://hg.mozilla.org/releases/comm-aurora/rev/b72d062cc0ed

Comment 5

[Kent James (:rkent)]

Comment on attachment 8721697 [details] [diff] [review]
adding the missing if (isForwarded)

http://hg.mozilla.org/releases/comm-esr45/rev/4f7be0c8a92b