Closed Bug 1249930 Opened 8 years ago Closed 8 years ago

menupopup shouldn't look for children in XBL anonymous content

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: surkov, Assigned: surkov)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
menupopup is just a container for menus and menuitems and no other content in it is accessible, so it makes sense to just ignore the anonymous content and don't traverse it at all.
Attachment #8721716 - Flags: review?(dbolter)
Summary: menupoup shouldn't look for children in XBL anonymous content → menupopup shouldn't look for children in XBL anonymous content
Comment on attachment 8721716 [details] [diff] [review]
patch

Review of attachment 8721716 [details] [diff] [review]:
-----------------------------------------------------------------

Hopefully doesn't bite us later.
Attachment #8721716 - Flags: review?(dbolter) → review+
Assignee: nobody → surkov.alexander
(In reply to David Bolter [:davidb] from comment #2)

> Hopefully doesn't bite us later.

that's why it lives in separate bug
https://hg.mozilla.org/integration/mozilla-inbound/rev/51c24b85e158132e4a6eb8ec09d95126c5ca07d2
Bug 1249930 - menupoup shouldn't look for children in XBL anonymous content, r=davidb
https://hg.mozilla.org/mozilla-central/rev/51c24b85e158
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: