Closed Bug 1250380 Opened 8 years ago Closed 8 years ago

Build Error in MediaEngineGonkVideoSource

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: cleu, Assigned: cleu)

Details

Attachments

(1 file)

Fix build error in MediaEngineGonkVideoSource
3.03 KB, patch
Details | Diff | Splinter Review 
Symptom:

Build failed in MediaEngineGonkVideoSource

Cause:

1. The overriding method "MediaEngineGonkVideoSource::Allocate"(takes 3 arguments) is inconsistent with its corresponding virtual method MediaEngineSource::Allocate (takes 4 arguments)

2. Missing headerfile in GrallocTextureClient.cpp

Solution:

1. Create a 4-argument wrapper of MediaEngineGonkVideoSource::Allocate
2. Add #include "gfxPrefs.h" in GrallocTextureClient.cpp
Assignee: nobody → cleu
Attachment #8722327 - Attachment description: Fix build error in MediaEngineGonkVideoSourc → Fix build error in MediaEngineGonkVideoSource
Attachment #8722327 - Flags: review?(fabrice)
I think the issue described here is already fixed by bug 1249245 and bug 1249244. What tree were you building from?
Attachment #8722327 - Flags: review?(fabrice)
I fetched the code via "./config.sh nexus-5" on Feb 19.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: