1250486 - get rid of some static ctors for xpconnect things

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: make some xpconnect wrapper ctors constexpr to get rid of static constructors

Comment 2

[Trevor Saunders (:tbsaunde)]

Attachment: make the ComponentsSH ctor constexpr

Comment 3

[Trevor Saunders (:tbsaunde)]

Attachment: get rid of the static ctor for XPCShellImpl.cpp

The dtor for PersistentRooted<> removes it from a linked list, which means we
need a static ctor to register that dtor with the atexit machinary.  So the
easiest thing to do is make sScriptedInterruptCallback a pointer that points to
a PersistentRootedValue we allocate on the heap.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8722480 [details] [diff] [review]
make some xpconnect wrapper ctors constexpr to get rid of static constructors

Review of attachment 8722480 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/wrappers/XrayWrapper.h
@@ +159,5 @@
>  
>  class DOMXrayTraits : public XrayTraits
>  {
>  public:
> +  MOZ_CONSTEXPR DOMXrayTraits() = default;

Indentation is off

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8722480 [details] [diff] [review]
make some xpconnect wrapper ctors constexpr to get rid of static constructors

>+    explicit MOZ_CONSTEXPR CrossOriginXrayWrapper(unsigned flags) :

The other use in this file has "MOZ_CONSTEXPR explicit".  Please match it, or if it's wrong fix it.

>+  MOZ_CONSTEXPR DOMXrayTraits() = default;

Indent by two more spaces.

r=me

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8722481 [details] [diff] [review]
make the ComponentsSH ctor constexpr

Ick.  Lying refcounting is ick.  r=me, but ick.  ;)

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8722482 [details] [diff] [review]
get rid of the static ctor for XPCShellImpl.cpp

r=me.  Having this sort of thing as a static seems moderately insane, but ok for this case...

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a0a84198d1c
https://hg.mozilla.org/integration/mozilla-inbound/rev/228b1d50058a
https://hg.mozilla.org/integration/mozilla-inbound/rev/324c6f120c8a

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8a0a84198d1c
https://hg.mozilla.org/mozilla-central/rev/228b1d50058a
https://hg.mozilla.org/mozilla-central/rev/324c6f120c8a