Closed
Bug 1250667
Opened 8 years ago
Closed 8 years ago
Add-ons in the test suite are unsigned
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(firefox46 fixed, firefox47 fixed)
RESOLVED
FIXED
Firefox 47
People
(Reporter: andy+bugzilla, Assigned: andy+bugzilla)
References
Details
Attachments
(1 file)
There are 5 add-ons here: https://dxr.mozilla.org/mozilla-central/source/devtools/client/debugger/test/mochitest That are unsigned, when signing is turned on in the tree, the tests will fail. The currently can't be signed because they were made using cfx, not jpm. Signing them against AMO will cause it fail: Due to breaking changes in Firefox 44, add-ons packed with the "cfx" tool won't work any longer... We'll either need to load them unsigned or convert them to JPM and load them signed.
Assignee | ||
Comment 1•8 years ago
|
||
I've got 3 of the addons converted from cfx to jpm and then signed all 5 of the addons. Unfortunately I ended up with 5 or 6 failing tests. Was having some try server problems, but once I've got that running, I'll ask for some help from #devtools I think :)
Assignee: nobody → amckay
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc6c8e8ece21
Component: Developer Tools → Developer Tools: Debugger
Assignee | ||
Comment 3•8 years ago
|
||
Signature failures are fixed. Got some new ones though. 234 INFO TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg_addon-sources.js | Should be two sources - Got 1, expected 2 235 INFO TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg_addon-sources.js | correct url for bootstrap code - 236 INFO TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg_addon-sources.js | correct label for bootstrap code - Got index.js, expected bootstrap.js 237 INFO TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg_addon-sources.js | A promise chain failed to handle a rejection: - at chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/browser_dbg_addon-sources.js:29 - TypeError: sources[1] is undefined 239 INFO TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg_addon-sources.js | Test timed out - 261 INFO TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg_addonactor.js | the main script of the addon is present in the source list -
Assignee | ||
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8fe98c8d008
Assignee | ||
Comment 5•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/36759/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/36759/
Attachment #8723839 -
Flags: review?(ahalberstadt)
Comment 6•8 years ago
|
||
Comment on attachment 8723839 [details] MozReview Request: bug 1250667 sign the devtools addons and bug687194.xpi r?ahal https://reviewboard.mozilla.org/r/36759/#review33391 Lgtm!
Attachment #8723839 -
Flags: review?(ahalberstadt) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a2ecc80c5e89
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Comment 9•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/5ce24a99fa1a
status-firefox46:
--- → fixed
Comment 10•8 years ago
|
||
[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•