Closed
Bug 1251088
Opened 8 years ago
Closed 8 years ago
need to update the stored mImageWidth/Height on ImageDocuments when we get the document load event
Categories
(Core :: Layout: Images, Video, and HTML Frames, defect)
Core
Layout: Images, Video, and HTML Frames
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
Attachments
(1 file)
1.35 KB,
patch
|
bzbarsky
:
review+
Sylvestre
:
approval-mozilla-esr45+
|
Details | Diff | Splinter Review |
Problem discovered in bug 1145903.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8723319 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 2•8 years ago
|
||
UpdateSizeFromLayout flushes, and then accesses member variables of this, so I guess we have a guarantee that the document stays alive somewhere? If not we need to add some safety here.
Comment 3•8 years ago
|
||
Comment on attachment 8723319 [details] [diff] [review] patch The only current caller of UpdateSizeFromLayout is HandleEvent, and event handling obviously holds strong refs to the node listeners will run on (because otherwise, other listeners firing before this one can kill the object). So the existing use is ok; this new use will need to take a strong ref to this.... r=me with that.
Attachment #8723319 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=78a079aa6708
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b15d2346d864
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 8•8 years ago
|
||
Bug 1145903 hits esr45 on a regular basis still. Is this something that'd be safe to uplift there?
Flags: needinfo?(tnikkel)
Assignee | ||
Comment 9•8 years ago
|
||
Comment on attachment 8723319 [details] [diff] [review] patch [Approval Request Comment] If this is not a sec:{high,crit} bug, please state case for ESR consideration: User impact if declined: sherriffs asked for this to fix an intermittent Fix Landed on Version: 48 Risk to taking this patch (and alternatives if risky): should be safe String or UUID changes made by this patch: none See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.
Flags: needinfo?(tnikkel)
Attachment #8723319 -
Flags: approval-mozilla-esr45?
Comment 10•8 years ago
|
||
Comment on attachment 8723319 [details] [diff] [review] patch Fix an intermittent, taking it to improve the life of sheriffs
Attachment #8723319 -
Flags: approval-mozilla-esr45? → approval-mozilla-esr45+
Updated•8 years ago
|
status-firefox-esr45:
--- → affected
Comment 11•8 years ago
|
||
Should be in 45.4
Comment 12•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-esr45/rev/5ffa912ed83e
Updated•6 years ago
|
Product: Core → Core Graveyard
Updated•6 years ago
|
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•