Closed
Bug 1251096
Opened 8 years ago
Closed 8 years ago
[FlyWeb] Allow multiple AN entries in mDNS responses when parsing with MulticastDNSFallback.jsm
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
People
(Reporter: djvj, Unassigned)
References
Details
Attachments
(1 file)
5.05 KB,
patch
|
justindarc
:
review+
|
Details | Diff | Splinter Review |
The JS implementation of the MDNS discovery code is pretty strict about its parsing, and doesn't handle some slightly-incorrect (yet still present in the wild) methods. mDNS responses should return a PTR records in the AN section, and any additional records in the AR section. However, some services respond with dns packets that contain all records in the AN section. Apple's implementation handles this fine. We should probably handle it as well.
Reporter | ||
Comment 1•8 years ago
|
||
Attachment #8723335 -
Flags: review?(jdarcangelo)
Comment 2•8 years ago
|
||
Comment on attachment 8723335 [details] [diff] [review] handle-multiple-entries-in-answer-section.patch LGTM
Attachment #8723335 -
Flags: review?(jdarcangelo) → review+
Reporter | ||
Comment 3•8 years ago
|
||
Landed: http://hg.mozilla.org/projects/larch/rev/df6a3c585249
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•